Skip to content

Conversation

@DTL2020
Copy link
Contributor

@DTL2020 DTL2020 commented Mar 7, 2023

division error

added fix for subsampled chroma shift in MCompensate (for QTGMC and other MC denoise scripts).
@pinterf
Copy link
Owner

pinterf commented Mar 8, 2023

If you force push with your fixes, your pull request will be renewed and won't contain fix of a previous wrong commit.

@DTL2020
Copy link
Contributor Author

DTL2020 commented Mar 8, 2023

If you force push with your fixes, your pull request will be renewed and won't contain fix of a previous wrong commit.

And how to 'force push' via github web-interface ? I thought the all changes (all sequential commits) of this branch 'fixed_css_error' will be merged in single pull-request.

@pinterf
Copy link
Owner

pinterf commented Mar 10, 2023

I think your differently named commits will all appear as you provided it.
If possible, I wouldn't like to see all the development and experimenting phase in the repo. Too many changes to and fro. This is why I lately removed partially imported changes from your branch from my mvtools2 repo on my home computer; there are some uncommitted changes on my side.

I suppose when you reset your local working branch (keep changes) and reapply commits and make a force-push it will automatically appear proeprly in the pull request, Lately an Avisynth contributors was routinely doing it, so it cannot be that difficult.

Like here, original pull request was made ready after several iterations:
AviSynth/AviSynthPlus#335

I, personally never used it from the other side, but I'm gonna try once to see how it works in real life.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants