-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Add PayloadToMimeType map to StreamInfo #3175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## master #3175 +/- ##
===========================================
- Coverage 78.03% 63.16% -14.87%
===========================================
Files 93 72 -21
Lines 11769 4697 -7072
===========================================
- Hits 9184 2967 -6217
+ Misses 2074 1572 -502
+ Partials 511 158 -353
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know how I feel about adding this, in one hand i see how this is required, but for people who read the code or use pion it might feels tricky to have a member with a generic name and redundant information. I meant for this PR and pion/interceptor#346
Thanks for reviewing it, is it possible to change the member in StreamInfo so it would fit? For example:
Or maybe it can be merged if I provide an example of using this new StreamInfo API by contributing RED FEC decoder interceptor to pion/interceptor/pkg/? |
This sound like a good call, we should only add the information that we need, We might need to refactor streaminfo by the next major version anyways so it contains a slice of codec values. |
@JoeTurki Is this better? I have replaced the Codecs field with the PayloadToMimeType map |
I like this more, but maybe we need to explain what it's doing in the code or maybe rename it to something more readable, not sure what will work best, but as of right now for someone reading the code they might have hard time understanding what it's actually doing! |
pion/interceptor#346