Skip to content

Conversation

5ur3
Copy link
Member

@5ur3 5ur3 commented Jul 8, 2025

Copy link

codecov bot commented Jul 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.16%. Comparing base (4c1af4c) to head (801af07).
⚠️ Report is 27 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (4c1af4c) and HEAD (801af07). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (4c1af4c) HEAD (801af07)
go 2 0
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #3175       +/-   ##
===========================================
- Coverage   78.03%   63.16%   -14.87%     
===========================================
  Files          93       72       -21     
  Lines       11769     4697     -7072     
===========================================
- Hits         9184     2967     -6217     
+ Misses       2074     1572      -502     
+ Partials      511      158      -353     
Flag Coverage Δ
go ?
wasm 63.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@JoeTurki JoeTurki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know how I feel about adding this, in one hand i see how this is required, but for people who read the code or use pion it might feels tricky to have a member with a generic name and redundant information. I meant for this PR and pion/interceptor#346

@5ur3
Copy link
Member Author

5ur3 commented Jul 8, 2025

Thanks for reviewing it, is it possible to change the member in StreamInfo so it would fit? For example:

  • Add a member that would contain only payload type and mime type (minimum amount of redundant information needed for RED FEC decoder interceptor implementation)
  • Store negotiated codecs information in private field and make a getter method: StreamInfo.GetCodecForPayloadType(uint8) (RTPCodecParameters, error)

Or maybe it can be merged if I provide an example of using this new StreamInfo API by contributing RED FEC decoder interceptor to pion/interceptor/pkg/?

@JoeTurki
Copy link
Member

JoeTurki commented Jul 8, 2025

Add a member that would contain only payload type and mime type (minimum amount of redundant information needed for RED FEC decoder interceptor implementation)

This sound like a good call, we should only add the information that we need, We might need to refactor streaminfo by the next major version anyways so it contains a slice of codec values.

@5ur3 5ur3 changed the title Add negotiated codec parameters to StreamInfo Add PayloadToMimeType to StreamInfo Jul 8, 2025
@5ur3 5ur3 changed the title Add PayloadToMimeType to StreamInfo Add PayloadToMimeType map to StreamInfo Jul 8, 2025
@5ur3
Copy link
Member Author

5ur3 commented Jul 8, 2025

@JoeTurki Is this better? I have replaced the Codecs field with the PayloadToMimeType map

@5ur3 5ur3 requested a review from JoeTurki July 9, 2025 10:59
@JoeTurki
Copy link
Member

@JoeTurki Is this better? I have replaced the Codecs field with the PayloadToMimeType map

I like this more, but maybe we need to explain what it's doing in the code or maybe rename it to something more readable, not sure what will work best, but as of right now for someone reading the code they might have hard time understanding what it's actually doing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants