Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,9 @@ language: ruby
before_install: "gem install bundler -v '< 2.0'"
script: "bundle exec rake ci"
rvm:
- 2.0
- 2.1
- 2.2
- 2.3
- 2.4
- 2.5
- 2.6
- 2.7
- 3.0
- 3.1
- 3.2
- ruby-head
- jruby-9.2.11.1
- jruby-head
Expand Down
2 changes: 1 addition & 1 deletion features/step_definitions/github_api_steps.rb
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@
end

Then /^the response collection of resources is different for "([^"]*)" attribute$/ do |attr|
@next_response.first.send(:"#{attr}").should_not eql @response.first.send(:"#{attr}")
expect(@next_response.first.send(:"#{attr}")).to_not eql @response.first.send(:"#{attr}")
end

Then /^this collection should include first page$/ do
Expand Down
2 changes: 1 addition & 1 deletion features/support/settings.rb
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,4 @@ def live_credentials?
true
end

SETTINGS = (live_credentials? && File.exists?(settings_file) && yaml= YAML.load_file(settings_file)) ? yaml : {'basic_auth' => 'login:password', 'oauth_token' => 'as79asfd79ads', 'user'=> 'murek', 'repo' => 'dummy', 'email' => 'email@example.com'}
SETTINGS = (live_credentials? && File.exist?(settings_file) && yaml= YAML.load_file(settings_file)) ? yaml : {'basic_auth' => 'login:password', 'oauth_token' => 'as79asfd79ads', 'user'=> 'murek', 'repo' => 'dummy', 'email' => 'email@example.com'}
4 changes: 2 additions & 2 deletions github_api.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ Gem::Specification.new do |gem|
gem.summary = "Ruby client for the official GitHub API"
gem.description = %q{ Ruby client that supports all of the GitHub API methods. It"s build in a modular way, that is, you can either instantiate the whole api wrapper Github.new or use parts of it e.i. Github::Client::Repos.new if working solely with repositories is your main concern. Intuitive query methods allow you easily call API endpoints. }
gem.license = "MIT"
gem.required_ruby_version = ">= 2.0.0"
gem.required_ruby_version = "~> 3.0"

gem.files = Dir["lib/**/*"]
gem.require_paths = %w[ lib ]
Expand All @@ -28,6 +28,6 @@ Gem::Specification.new do |gem|
gem.add_development_dependency "cucumber", "~> 2.1"
gem.add_development_dependency "rspec", "~> 3"
gem.add_development_dependency "rspec-its","~> 1"
gem.add_development_dependency "vcr", "~> 3.0.3"
gem.add_development_dependency "vcr", "~> 6.0"
gem.add_development_dependency "webmock", "~> 3.8"
end
10 changes: 5 additions & 5 deletions spec/github/pagination/iterator/number_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@

it 'performs request' do
expect(iterator).to receive(:page_request).
with("/users/#{user}/repos", 'per_page' => 20, 'page' => 1).
with("/users/#{user}/repos", { 'per_page' => 20, 'page' => 1 }).
and_return(response)
iterator.first
end
Expand All @@ -72,7 +72,7 @@

it 'performs request' do
expect(iterator).to receive(:page_request).
with("/users/#{user}/repos", 'page' => 4,'per_page' => 20).
with("/users/#{user}/repos", { 'page' => 4,'per_page' => 20 }).
and_return(response)
iterator.next
end
Expand All @@ -86,7 +86,7 @@

it 'performs request' do
expect(iterator).to receive(:page_request).
with("/users/#{user}/repos", 'page' => 2,'per_page' => 20).
with("/users/#{user}/repos", { 'page' => 2,'per_page' => 20 }).
and_return(response)
iterator.prev
end
Expand All @@ -100,7 +100,7 @@

it 'performs request' do
expect(iterator).to receive(:page_request).
with("/users/#{user}/repos", 'page' => 6,'per_page' => 20).
with("/users/#{user}/repos", { 'page' => 6,'per_page' => 20 }).
and_return(response)
iterator.last
end
Expand All @@ -115,7 +115,7 @@

it 'performs request' do
expect(iterator).to receive(:page_request).
with("/users/#{user}/repos", 'page' => 2,'per_page' => 20).
with("/users/#{user}/repos", { 'page' => 2,'per_page' => 20 }).
and_return(response)
iterator.get_page(2)
end
Expand Down
6 changes: 3 additions & 3 deletions spec/github/pagination/iterator/sha_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -49,16 +49,16 @@
it 'performs request' do
expect(iterator).to receive(:page_request).
with("/repos/peter-murach/github/commits",
'sha' => 'master', 'per_page' => 30).and_return(response)
{ 'sha' => 'master', 'per_page' => 30 }).and_return(response)
iterator.first
end
end

context 'next page request' do
it 'performs request' do
expect(iterator).to receive(:page_request).
with("/repos/peter-murach/github/commits", 'last_sha' => last_sha,
'sha' => last_sha, 'per_page' => 30, 'top' => top_sha).
with("/repos/peter-murach/github/commits", { 'last_sha' => last_sha,
'sha' => last_sha, 'per_page' => 30, 'top' => top_sha }).
and_return(response)
iterator.next
end
Expand Down