Rely on the digest class defined by Rails #173
Merged
+6
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameerpathan111
approved these changes
Feb 5, 2025
|
@mathieujobin Could you take a look when you get a chance, and if you merge the change a follow up release would be greatly appreciated. Additional context is available in our project's tracker -- https://projects.theforeman.org/issues/38118 |
mathieujobin
approved these changes
Feb 8, 2025
|
The tests are unrelated to this change, I have opened a PR to fix them separately -- #174 |
ekohl
reviewed
Feb 17, 2025
Rails applications can override the digest class through configuration settings. Further, Rails does this by default in versions suchs as 7 where it defaults to SHA256. Using ActiveSupport::Digest directly skips over this setting causing it to always be MD5 in the current state. This breaks in modern environments MD5 is disabled such as FIPS environments. Signed-off-by: Eric D. Helms <ericdhelms@gmail.com>
ekohl
approved these changes
Feb 17, 2025
|
@mathieujobin Can you take another look? |
|
I will try to release it tomorrow or in the following days, ping me again if I forget |
|
Awesome, thank you so much! |
|
@mathieujobin friendly ping ;-) |
|
Sorry for the wait ! enjoy your weekend
is out in the wild |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rails applications can override the digest class through configuration settings. Further, Rails does this by default in versions suchs as 7 where it defaults to SHA256. Using ActiveSupport::Digest directly skips over this setting causing it to always be MD5 in the current state. This breaks in modern environments MD5 is disabled such as FIPS environments.