Skip to content

InheritsCheck: Whitelist branding.eclass from UnusedInherits #766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chewi wants to merge 1 commit into
base: master
Choose a base branch
from
Open

InheritsCheck: Whitelist branding.eclass from UnusedInherits #766

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/pkgcheck/checks/codingstyle.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -817,6 +817,10 @@ class InheritsCheck(Check):
)
required_addons = (addons.eclass.EclassAddon,)

# branding.eclass can be used purely for variables recognised by external
# build tools rather than the ebuild itself.
unused_whitelist = frozenset({"branding"})

def __init__(self, *args, eclass_addon):
super().__init__(*args)
self.eclass_cache = eclass_addon.eclasses
Expand Down Expand Up @@ -961,7 +965,11 @@ def feed(self, pkg):
)
if exported_eclass_keys.intersection(self.unused_eclass_skiplist):
unused.discard(eclass)
elif not self.eclass_cache[eclass].exported_function_names and exported_eclass_keys:
elif (
not self.eclass_cache[eclass].exported_function_names
and exported_eclass_keys
or eclass in self.unused_whitelist
):
# ignore eclasses that export ebuild metadata (e.g.
# SRC_URI, S, ...) and no functions
unused.discard(eclass)
Expand Down
Loading