Resolve msaa when needed #177
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ideally we would not resolve depth .. as this is the only code at the moment that does it, and it's not compatible with WebGl1 nor WebGPU. I'd prefer we remove depth parameter to RenderTarget.resolve and implement this feature using SceneDepth. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The viewer was resolving color & depth buffers every frame, even though depth was not always needed.
This PR updates the viewer to only resolve color buffers every frame and then resolve depth buffer when it's required.
This change saves 3.0ms per frame when rendering 4xMSAA at 1440p on macbook ATI hardware.