-
Notifications
You must be signed in to change notification settings - Fork 24
Add support for syncing all file types for both pcwatch and pcsync #72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
willeastcott
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the contribution. I think someone else should also cast an eye. @kpal81xd, can you also do a review pass before we merge please?
|
Sometimes this error is thrown: |
|
Just pushed an issue that fixes this. One of the util files assumed that a download was a file. Also, I fixed an issue where pulling changes showed many missing files/directories on local that exist on remote. What actually is happening is that PlayCanvas handles some files as directories (fbx, glb, etc.) but when you download them via API, they download as files. |
|
TODO: Deleting local files that have already been deleted on remote causes crash |
kpal81xd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple comments for layout but otherwise looks good nice 🙂
Pushed a fix for this: fabc1a8 |
|
I agree with this issue. This PR could include this change. It's a bit confusing to run |
…eting files calls WatchUtils.reportWatchAction() now
pcwatchpcwatchandpcsync