Skip to content

Fix issue #3417: Add unique ID for independent timer operation #3418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix issue #3417: Add unique ID for independent timer operation #3418

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions ...MeetTheComposableArchitecture/01-Essentials/02-AddingSideEffects/01-02-03-code-0005.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ struct CounterFeature {
var fact: String?
var isLoading = false
var isTimerRunning = false
let timerID = UUID()
}

enum Action {
Expand All @@ -19,7 +20,7 @@ struct CounterFeature {
case toggleTimerButtonTapped
}

enum CancelID { case timer }
enum CancelID: Hashable { case timer(UUID) }

var body: some ReducerOf<Self> {
Reduce { state, action in
Expand Down Expand Up @@ -56,16 +57,17 @@ struct CounterFeature {

case .toggleTimerButtonTapped:
state.isTimerRunning.toggle()
let cancelID = CancelID.timer(state.timerID)
if state.isTimerRunning {
return .run { send in
while true {
try await Task.sleep(for: .seconds(1))
await send(.timerTick)
}
}
.cancellable(id: CancelID.timer)
.cancellable(id: cancelID)
} else {
return .cancel(id: CancelID.timer)
return .cancel(id: cancelID)
}
}
}
Expand Down