feat: upgrade Express to support v5 #246
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 85a18a9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
maratsh
approved these changes
Jul 27, 2025
|
We should probably support Express 4 & 5 for a while. |
|
Can you share what do you mean by that? |
|
The current PR will require users to either fix their Polar Express adapter version and stay on Express 4, or upgrade to Express 5 to keep access to the newer versions of the Polar Express adapter, even though we don't rely on any Express 5 features. It feels unnecessary to force users to a major version upgrade for Express while Express 4 is not EOL yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #247
@emilwidlund
I felt safe raising this PR since I saw no new errors with the update (and per https://expressjs.com/en/guide/migrating-5.html and my [quick] read of the existing code things should not be broken between either versions) and after fixing the tests to match the latest syntax,
pnpm testpassed.