-
Notifications
You must be signed in to change notification settings - Fork 74
Fix local dev node #1226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: staging/product-ia
Are you sure you want to change the base?
Fix local dev node #1226
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes the local development node documentation by removing an outdated warning banner and a specific git checkout command. The changes primarily affect the smart contracts local dev node guide and include regenerated AI-generated documentation files.
- Removed the PolkaVM preview warning banner
- Removed the git checkout command that pinned to a specific commit
- Cleaned up formatting by removing an extra blank line
Reviewed Changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| smart-contracts/dev-environments/local-dev-node.md | Removed PolkaVM warning banner, removed git checkout command, and cleaned up formatting |
| llms.txt, llms-full.jsonl | Regenerated AI documentation files reflecting the documentation changes |
| .ai/pages/smart-contracts-dev-environments-local-dev-node.md | Updated AI-generated page content |
| .ai/pages/reference.md | Added new Technical Reference Overview content (appears to be separate enhancement) |
| .ai/site-index.json | Updated metadata for the reference page |
| .ai/categories/*.md | Regenerated category files with updated reference page content |
Comments suppressed due to low confidence (1)
smart-contracts/dev-environments/local-dev-node.md:26
- The links in this paragraph still reference
{{dependencies.repositories.polkadot_sdk_contracts_node.commit_dev_node}}, which points to a specific commit hash (8e2b6f742a38bb13688e12abacded0aab2dbbb23). This creates an inconsistency: the links point to a specific commit, but the instructions below don't check out that commit. Either update these links to point tomasterormainbranch, or restore the git checkout command to match the linked commit.
The Polkadot SDK repository contains both the [Revive Dev node](https://github.com/paritytech/polkadot-sdk/tree/{{dependencies.repositories.polkadot_sdk_contracts_node.commit_dev_node}}/substrate/frame/revive/dev-node){target=\_blank} implementation and the [ETH-RPC adapter](https://github.com/paritytech/polkadot-sdk/tree/{{dependencies.repositories.polkadot_sdk_contracts_node.commit_dev_node}}/substrate/frame/revive/rpc){target=\_blank} required for Ethereum compatibility. Start by cloning the repository and navigating to the project directory:
π‘ Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| ```bash | ||
| git clone https://github.com/paritytech/polkadot-sdk.git | ||
| cd polkadot-sdk |
Copilot
AI
Nov 12, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing the git checkout command without pinning to a specific version creates reproducibility issues. Users following this guide will clone the latest main branch, which may contain breaking changes or incompatibilities. Consider either: (1) keeping the checkout command with an updated commit hash, (2) checking out a stable release tag (e.g., git checkout polkadot-stable2409), or (3) documenting which version/branch users should use.
| cd polkadot-sdk | |
| cd polkadot-sdk | |
| git checkout polkadot-stable2409 |
|
@brunopgalvao if this looks good, pls merge. Thanks! |
Solves #1219
π Description
Provide a clear and concise description of your changes.
π Review Preference
Choose one:
π€ AI-Ready Docs
If content changed, regenerate AI files:
python3 scripts/generate_llms.pyβ Checklist