Skip to content

Conversation

@tautropfli
Copy link
Member

Resolves #823

FreeApophis
FreeApophis previously approved these changes Jan 30, 2025
@FreeApophis
Copy link
Member

FreeApophis commented Jan 30, 2025

NuGet generation fails with: error MSB4018: The "GenerateSemanticVersionRanges" task failed unexpectedly.

@tautropfli
Copy link
Member Author

I decided to extract this into its own package. This makes the whole dependency thing a lot easier (I can pack NuGet.SemanticVersioning together with the task) and allows us to use it in other repos too :)

See: polyadic/build#1

@FreeApophis
Copy link
Member

Still do not understand what it actually should do.

@tautropfli
Copy link
Member Author

Still do not understand what it actually should do.

The goal or the implementation?

@tautropfli tautropfli force-pushed the fix-semantic-versioning-targets branch from 9ac2bcb to 0fceea4 Compare January 30, 2025 16:15
@FreeApophis
Copy link
Member

I think I do not understand the goal, and therefore the implementation does not help.

@tautropfli
Copy link
Member Author

Ah 😅

The goal is to reference Funcky using a semantic version range e.g. [3.5.0, 4) from the other NuGet packages in this repo instead of the default >=3.5.0.

The implementation does this by hooking into the pack process (that's what the Polyadic.Build.SemanticVersioning.targets file does).
It replaces the versions of each ProjectReference with an auto-generated range (that's what the GenerateSemanticVersionRanges is for).

@tautropfli tautropfli merged commit 5ca841b into main Feb 3, 2025
9 checks passed
@tautropfli tautropfli deleted the fix-semantic-versioning-targets branch February 3, 2025 09:46
@FreeApophis
Copy link
Member

I see - the problem was not xUnit but the fact that it is project reference. No wonder I was confused. Approved and merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SemanticVersioning.targets breaks build on VisualStudio

3 participants