Skip to content

Change .baseurl to .url in sidebar.html #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: v3
Choose a base branch
from
Open

Change .baseurl to .url in sidebar.html #260

wants to merge 1 commit into from

Conversation

xia0nan
Copy link

@xia0nan xia0nan commented May 6, 2020

It fixes the issue of failing to redirect to home page
since in v3 the baseurl has been set to empty

@xia0nan
Change .baseurl to .url in sidebar.html
4e7d889 
It fixes the issue of failing to redirect to home page
since in v3 the baseurl has been set to empty
derhagen
derhagen suggested changes Oct 25, 2020
View reviewed changes
Copy link

@derhagen derhagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would actually ignore any values set for baseurl. You should append site.baseurl to site.url, which produces the same effect as long as baseurl is empty.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@derhagen derhagen derhagen requested changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xia0nan @derhagen