Skip to content

Port 14552 deployment environment tags releases #2557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Aug 11, 2025

Conversation

melodyogonna
Copy link
Contributor

Description

Remaining examples for tags, releases, environments, and deployments

Updated docs pages

Please also include the path for the updated docs

  • Examples (/build-your-software-catalog/sync-data-to-catalog/git/github-ocean/examples)

Base automatically changed from PORT-14552-document-github-ocean to main July 31, 2025 08:28
Copy link

claude bot commented Aug 4, 2025

Claude finished @melodyogonna's task —— View job


PR Review: Port 14552 deployment environment tags releases

Review Tasks:

  • Read CONTRIBUTING.md guidelines
  • Review documentation structure and consistency
  • Check technical accuracy of examples
  • Verify formatting and style compliance
  • Provide detailed feedback

Overall Assessment

This PR successfully adds comprehensive examples for GitHub Ocean integration covering deployments, environments, releases, and tags. The documentation follows most of the established patterns and provides valuable examples for users.

✅ Positive Aspects

  1. Comprehensive Coverage: The PR adds examples for all promised resource types (deployments, environments, releases, tags)
  2. Consistent Structure: New files follow the existing pattern of using <details> summaries with code blocks
  3. Proper Integration: Well-integrated into the main examples page with appropriate imports and sections
  4. Technical Accuracy: The JSON blueprints and YAML configurations appear technically sound
  5. Live Events Update: Correctly updated the live events component to include deployment and release events

🔧 Issues to Address

1. Critical: Inconsistent Summary Formatting

Files: _github_exporter_example_environment_blueprint.mdx:2, _github_exporter_example_deployments_and_environments_port_app_config.mdx:3

  • Environment blueprint uses "Running Service blueprint" instead of "Environment blueprint"
  • Config file has extra space: <summary> Port port-app-config.yml </summary> should be <summary>Port port-app-config.yml</summary>

2. Minor: Terminology Consistency

Files: Multiple blueprint files

  • The environment blueprint refers to "Running Service" in multiple places, but this should be "Environment" for clarity
  • Deployment blueprint properties use "Running Service" instead of "Environment" in labels (lines 24, 28)

3. Code Style Issues

File: _github_exporter_example_tag_blueprint.mdx:5

  • Empty line after opening code block should be removed

File: _github_exporter_example_deployments_and_environments_port_app_config.mdx:32

  • Property name customBranchesPolicies should be customBranchPolicies (matches blueprint)

File: _github_exporter_example_deployments_and_environments_port_app_config.mdx:56

  • Relation should be runningService not environment to match the blueprint relation name

4. Documentation Style

Files: Various examples

Per CONTRIBUTING.md guidelines:

  • All code blocks should use showLineNumbers (some are missing this)
  • Consider using consistent summary text formatting

📝 Specific Line-by-Line Issues

  1. _github_exporter_example_environment_blueprint.mdx:2: Change "Running Service blueprint" to "Environment blueprint"

  2. _github_exporter_example_deployment_blueprint.mdx:24,28: Change "Running Service" to "Environment" in property titles

  3. _github_exporter_example_deployments_and_environments_port_app_config.mdx:32: Fix typo customBranchesPoliciescustomBranchPolicies

  4. _github_exporter_example_deployments_and_environments_port_app_config.mdx:56: Change relation from environment to runningService

  5. _github_exporter_example_tag_blueprint.mdx:5: Remove empty line after opening code block

🎯 Recommendations

  1. Fix the critical blueprint/config mismatches - The deployment relations need to align properly
  2. Standardize terminology - Use "Environment" consistently instead of mixing with "Running Service"
  3. Add missing showLineNumbers to code blocks as per style guide
  4. Test the configurations - Ensure the YAML configs actually work with the provided blueprints

Summary

This is a solid contribution that adds valuable documentation examples. The main issues are around consistency in naming/terminology and some minor configuration mismatches that should be addressed to ensure the examples work correctly for users.

Priority: Address the blueprint/config relation mismatches first, then the terminology consistency issues.


Copy link

claude bot commented Aug 5, 2025

Claude finished @melodyogonna's task —— View job


PR Review Tasks:

  • Read CONTRIBUTING.md guidelines
  • Review all changed files for compliance
  • Check technical accuracy of examples
  • Verify formatting and style consistency
  • Provide comprehensive review feedback

PR Review: GitHub Ocean Integration Examples

This PR adds comprehensive examples for GitHub Ocean integration covering deployments, environments, releases, and tags. Here's my detailed review according to the CONTRIBUTING.md guidelines:

✅ Positive Aspects

  1. Comprehensive Coverage: Successfully adds examples for all promised resource types (deployments, environments, releases, tags)
  2. Good Structure: Follows the established pattern of using <details> summaries with code blocks
  3. Proper Integration: Well-integrated into the main examples page with appropriate imports
  4. Technical Sound: JSON blueprints and YAML configurations appear technically accurate
  5. Live Events Update: Correctly updated the live events component to include deployment and release events

🔧 Issues Requiring Attention

Critical Issues

  1. Inconsistent Summary Formatting (Files: _github_exporter_example_environment_blueprint.mdx:2, _github_exporter_example_deployments_and_environments_port_app_config.mdx:3)

    • Environment blueprint uses "Running Service blueprint" instead of "Environment blueprint"
    • Config file has extra space: <summary> Port port-app-config.yml </summary> should be <summary>Port port-app-config.yml</summary>
  2. Configuration Mismatch (_github_exporter_example_deployments_and_environments_port_app_config.mdx:32,56)

    • Line 32: customBranchesPolicies should be customBranchPolicies (matches blueprint)
    • Line 56: Relation should be runningService not environment to match the blueprint relation name

Style & Consistency Issues

  1. Code Block Formatting (_github_exporter_example_tag_blueprint.mdx:5)

    • Empty line after opening code block should be removed per style guidelines
  2. Terminology Consistency (Multiple blueprint files)

    • Environment blueprint refers to "Running Service" instead of "Environment"
    • Deployment blueprint properties (lines 24, 28) use "Running Service" instead of "Environment" in labels
  3. Missing showLineNumbers

    • Per CONTRIBUTING.md line 94: "Always include showLineNumbers for code blocks with more than one line"
    • The deployments config file is missing this attribute

📝 Specific Line-by-Line Issues

File Line Issue Fix
_github_exporter_example_environment_blueprint.mdx 2 "Running Service blueprint" Change to "Environment blueprint"
_github_exporter_example_deployment_blueprint.mdx 24,28 "Running Service" in titles Change to "Environment"
_github_exporter_example_deployments_and_environments_port_app_config.mdx 3 Extra space in summary Remove space: <summary>Port port-app-config.yml</summary>
_github_exporter_example_deployments_and_environments_port_app_config.mdx 32 customBranchesPolicies typo Change to customBranchPolicies
_github_exporter_example_deployments_and_environments_port_app_config.mdx 56 Wrong relation name Change environment to runningService
_github_exporter_example_tag_blueprint.mdx 5 Empty line after code block Remove empty line

🎯 Recommendations

  1. Fix Critical Mismatches: The blueprint/config relation mismatches could cause runtime issues
  2. Standardize Terminology: Use "Environment" consistently instead of mixing with "Running Service"
  3. Add Missing Attributes: Include showLineNumbers on all multi-line code blocks
  4. Test Configurations: Ensure YAML configs work with the provided blueprints

Summary

This is a valuable addition to the documentation that provides comprehensive examples for GitHub Ocean integration. The main issues are around consistency in naming/terminology and some configuration mismatches that need to be addressed to ensure the examples work correctly for users.

Priority: Address the blueprint/config relation mismatches first, then the terminology consistency issues.

Overall Assessment: ✅ Approve with requested changes

Copy link

claude bot commented Aug 6, 2025

Claude finished @melodyogonna's task —— View job


PR Review Tasks

  • Read CONTRIBUTING.md guidelines
  • Review all changed files for compliance
  • Check technical accuracy of examples
  • Verify formatting and style consistency
  • Provide comprehensive review feedback

PR Review: GitHub Ocean Integration Examples

This PR adds comprehensive examples for GitHub Ocean integration covering deployments, environments, releases, and tags. Here's my detailed review according to the CONTRIBUTING.md guidelines:

✅ Positive Aspects

  1. Comprehensive Coverage: Successfully adds examples for all promised resource types (deployments, environments, releases, tags)
  2. Good Structure: Follows the established pattern of using <details> summaries with code blocks
  3. Proper Integration: Well-integrated into the main examples page with appropriate imports
  4. Technical Sound: JSON blueprints and YAML configurations appear technically accurate
  5. Live Events Update: Correctly updated the live events component to include deployment and release events

🔧 Issues Requiring Attention

Critical Issues

  1. Inconsistent Summary Formatting (_github_exporter_example_environment_blueprint.mdx:2, _github_exporter_example_deployments_and_environments_port_app_config.mdx:3)

    • Environment blueprint uses "Running Service blueprint" instead of "Environment blueprint"
    • Config file has extra space: <summary> Port port-app-config.yml </summary> should be <summary>Port port-app-config.yml</summary>
  2. Configuration Mismatch (_github_exporter_example_deployments_and_environments_port_app_config.mdx:32,56)

    • Line 32: customBranchesPolicies should be customBranchPolicies (matches blueprint)
    • Line 56: Relation should be runningService not environment to match the blueprint relation name

Style & Consistency Issues

  1. Code Block Formatting (_github_exporter_example_tag_blueprint.mdx:5)

    • Empty line after opening code block should be removed per style guidelines
  2. Terminology Consistency (Multiple blueprint files)

    • Environment blueprint refers to "Running Service" instead of "Environment"
    • Deployment blueprint properties (lines 24, 28) use "Running Service" instead of "Environment" in labels
  3. Missing showLineNumbers

    • Per CONTRIBUTING.md line 94: "Always include showLineNumbers for code blocks with more than one line"
    • The deployments config file is missing this attribute

📝 Specific Line-by-Line Issues

File Line Issue Fix
_github_exporter_example_environment_blueprint.mdx 2 "Running Service blueprint" Change to "Environment blueprint"
_github_exporter_example_deployment_blueprint.mdx 24,28 "Running Service" in titles Change to "Environment"
_github_exporter_example_deployments_and_environments_port_app_config.mdx 3 Extra space in summary Remove space: <summary>Port port-app-config.yml</summary>
_github_exporter_example_deployments_and_environments_port_app_config.mdx 32 customBranchesPolicies typo Change to customBranchPolicies
_github_exporter_example_deployments_and_environments_port_app_config.mdx 56 Wrong relation name Change environment to runningService
_github_exporter_example_tag_blueprint.mdx 5 Empty line after code block Remove empty line

🎯 Recommendations

  1. Fix Critical Mismatches: The blueprint/config relation mismatches could cause runtime issues
  2. Standardize Terminology: Use "Environment" consistently instead of mixing with "Running Service"
  3. Add Missing Attributes: Include showLineNumbers on all multi-line code blocks
  4. Test Configurations: Ensure YAML configs work with the provided blueprints

Summary

This is a valuable addition to the documentation that provides comprehensive examples for GitHub Ocean integration. The main issues are around consistency in naming/terminology and some configuration mismatches that need to be addressed to ensure the examples work correctly for users.

Priority: Address the blueprint/config relation mismatches first, then the terminology consistency issues.

Overall Assessment: ✅ Approve with requested changes

…hub.com:port-labs/port-docs into PORT-14552-deployment-environment-tags-releases
Copy link

claude bot commented Aug 6, 2025

Claude finished @melodyogonna's task —— View job


PR Review Tasks

  • Read CONTRIBUTING.md guidelines
  • Review all changed files for compliance
  • Check technical accuracy of examples
  • Verify formatting and style consistency
  • Provide comprehensive review feedback

PR Review: GitHub Ocean Integration Examples

This PR adds comprehensive examples for GitHub Ocean integration covering deployments, environments, releases, and tags. Here's my detailed review according to the CONTRIBUTING.md guidelines:

✅ Positive Aspects

  1. Comprehensive Coverage: Successfully adds examples for all promised resource types (deployments, environments, releases, tags)
  2. Good Structure: Follows the established pattern of using <details> summaries with code blocks
  3. Proper Integration: Well-integrated into the main examples page with appropriate imports
  4. Technical Sound: JSON blueprints and YAML configurations appear technically accurate
  5. Live Events Update: Correctly updated the live events component to include deployment and release events

🔧 Issues Requiring Attention

Critical Issues

  1. Inconsistent Summary Formatting (_github_exporter_example_environment_blueprint.mdx:2, _github_exporter_example_deployments_and_environments_port_app_config.mdx:3)

    • Environment blueprint uses "Running Service blueprint" instead of "Environment blueprint"
    • Config file has extra space: <summary> Port port-app-config.yml </summary> should be <summary>Port port-app-config.yml</summary>
  2. Configuration Mismatch (_github_exporter_example_deployments_and_environments_port_app_config.mdx:32,56)

    • Line 32: customBranchesPolicies should be customBranchPolicies (matches blueprint)
    • Line 56: Relation should be runningService not environment to match the blueprint relation name

Style & Consistency Issues

  1. Code Block Formatting (_github_exporter_example_tag_blueprint.mdx:5)

    • Empty line after opening code block should be removed per style guidelines
  2. Terminology Consistency (Multiple blueprint files)

    • Environment blueprint refers to "Running Service" instead of "Environment"
    • Deployment blueprint properties (lines 24, 28) use "Running Service" instead of "Environment" in labels
  3. Missing showLineNumbers

    • Per CONTRIBUTING.md line 94: "Always include showLineNumbers for code blocks with more than one line"
    • The deployments config file is missing this attribute

📝 Specific Line-by-Line Issues

File Line Issue Fix
_github_exporter_example_environment_blueprint.mdx 2 "Running Service blueprint" Change to "Environment blueprint"
_github_exporter_example_deployment_blueprint.mdx 24,28 "Running Service" in titles Change to "Environment"
_github_exporter_example_deployments_and_environments_port_app_config.mdx 3 Extra space in summary Remove space: <summary>Port port-app-config.yml</summary>
_github_exporter_example_deployments_and_environments_port_app_config.mdx 32 customBranchesPolicies typo Change to customBranchPolicies
_github_exporter_example_deployments_and_environments_port_app_config.mdx 56 Wrong relation name Change environment to runningService
_github_exporter_example_tag_blueprint.mdx 5 Empty line after code block Remove empty line
_github_exporter_example_deployments_and_environments_port_app_config.mdx 5 Missing showLineNumbers Add showLineNumbers to yaml code block

🎯 Recommendations

  1. Fix Critical Mismatches: The blueprint/config relation mismatches could cause runtime issues
  2. Standardize Terminology: Use "Environment" consistently instead of mixing with "Running Service"
  3. Add Missing Attributes: Include showLineNumbers on all multi-line code blocks
  4. Test Configurations: Ensure YAML configs work with the provided blueprints

Summary

This is a valuable addition to the documentation that provides comprehensive examples for GitHub Ocean integration. The main issues are around consistency in naming/terminology and some configuration mismatches that need to be addressed to ensure the examples work correctly for users.

Priority: Address the blueprint/config relation mismatches first, then the terminology consistency issues.

Overall Assessment: ✅ Approve with requested changes


Copy link

claude bot commented Aug 6, 2025

Claude finished @melodyogonna's task —— View job


PR Review Tasks

  • Read CONTRIBUTING.md guidelines
  • Review all changed files for compliance
  • Check technical accuracy of examples
  • Verify formatting and style consistency
  • Provide comprehensive review feedback

PR Review: GitHub Ocean Integration Examples

This PR adds comprehensive examples for GitHub Ocean integration covering deployments, environments, releases, and tags. Here's my detailed review according to the CONTRIBUTING.md guidelines:

✅ Positive Aspects

  1. Comprehensive Coverage: Successfully adds examples for all promised resource types (deployments, environments, releases, tags)
  2. Good Structure: Follows the established pattern of using <details> summaries with code blocks
  3. Proper Integration: Well-integrated into the main examples page with appropriate imports
  4. Technical Sound: JSON blueprints and YAML configurations appear technically accurate
  5. Live Events Update: Correctly updated the live events component to include deployment and release events

🔧 Issues Requiring Attention

Critical Issues

  1. Inconsistent Summary Formatting (_github_exporter_example_environment_blueprint.mdx:2, _github_exporter_example_deployments_and_environments_port_app_config.mdx:3)

    • Environment blueprint uses "Running Service blueprint" instead of "Environment blueprint"
    • Config file has extra space: <summary><b> Port port-app-config.yml (click to expand)</b></summary> should be <summary><b>Port port-app-config.yml (click to expand)</b></summary>
  2. Configuration Mismatch (_github_exporter_example_deployments_and_environments_port_app_config.mdx:32,56)

    • Line 32: customBranchesPolicies should be customBranchPolicies (matches blueprint)
    • Line 56: Relation should be runningService not environment to match the blueprint relation name

Style & Consistency Issues

  1. Terminology Consistency (Multiple blueprint files)

    • Environment blueprint refers to "Running Service" instead of "Environment"
    • Deployment blueprint properties (lines 24, 28) use "Running Service" instead of "Environment" in labels
  2. CONTRIBUTING.md Compliance Issues

    • Per line 94: "Always include showLineNumbers for code blocks with more than one line" - all code blocks correctly have this ✅
    • Per line 135-142: Summary/details formatting should use <summary><b>Title (click to expand)</b></summary> pattern - most follow this correctly ✅

📝 Specific Line-by-Line Issues

File Line Issue Fix
_github_exporter_example_environment_blueprint.mdx 2 "Running Service blueprint" Change to "Environment blueprint"
_github_exporter_example_deployment_blueprint.mdx 24,28 "Running Service" in titles Change to "Environment"
_github_exporter_example_deployments_and_environments_port_app_config.mdx 3 Extra space in summary Remove space: <summary><b>Port port-app-config.yml (click to expand)</b></summary>
_github_exporter_example_deployments_and_environments_port_app_config.mdx 32 customBranchesPolicies typo Change to customBranchPolicies
_github_exporter_example_deployments_and_environments_port_app_config.mdx 56 Wrong relation name Change environment to runningService

🎯 Recommendations

  1. Fix Critical Mismatches: The blueprint/config relation mismatches could cause runtime issues
  2. Standardize Terminology: Use "Environment" consistently instead of mixing with "Running Service"
  3. Test Configurations: Ensure YAML configs work with the provided blueprints

Summary

This is a valuable addition to the documentation that provides comprehensive examples for GitHub Ocean integration. The main issues are around consistency in naming/terminology and some configuration mismatches that need to be addressed to ensure the examples work correctly for users.

Priority: Address the blueprint/config relation mismatches first, then the terminology consistency issues.

Overall Assessment: ✅ Approve with requested changes


Copy link
Member

@matan84 matan84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot deleted a comment from claude bot Aug 10, 2025
@github-actions github-actions bot deleted a comment from claude bot Aug 11, 2025
@github-actions github-actions bot deleted a comment from claude bot Aug 11, 2025
Copy link

claude bot commented Aug 11, 2025

Claude finished @melodyogonna's task —— View job


PR Review: GitHub Ocean Integration Examples

Review Tasks:

  • Read CONTRIBUTING.md guidelines
  • Review all changed files for compliance
  • Check technical accuracy of examples
  • Verify formatting and style consistency
  • Address recent review comments from sivanel97
  • Provide comprehensive review feedback

Overall Assessment

This PR successfully adds comprehensive examples for GitHub Ocean integration covering deployments, environments, releases, and tags. The documentation follows most established patterns and provides valuable examples for users.

✅ Positive Aspects

  1. Comprehensive Coverage: Successfully adds examples for all promised resource types (deployments, environments, releases, tags)
  2. Good Structure: Follows the established pattern of using <details> summaries with code blocks
  3. Proper Integration: Well-integrated into the main examples page with appropriate imports
  4. Technical Sound: JSON blueprints and YAML configurations appear technically accurate
  5. Live Events Update: Correctly updated the live events component to include deployment and release events
  6. Compliance: Code blocks properly include showLineNumbers as required by CONTRIBUTING.md:94

🔧 Issues Requiring Attention

Critical Issues

  1. Summary Formatting Issues

    • _github_exporter_example_environment_blueprint.mdx:2: Uses "Deployment Environment blueprint" instead of "Environment blueprint"
    • _github_exporter_example_release_tag_port_app_config.mdx:3: Extra space: <summary><b> Port port-app-config.yml (click to expand)</b></summary> should be <summary><b>Port port-app-config.yml (click to expand)</b></summary>
  2. Terminology Consistency Issues

    • _github_exporter_example_deployment_blueprint.mdx:24,28: Properties use "Running Service" instead of "Environment" in titles:
      • Line 24: "Transient Running Service" should be "Transient Environment"
      • Line 28: "Production Running Service" should be "Production Environment"

Style & Formatting Issues

  1. Per sivanel97's Review Comments: The main examples.md file needs text improvements for better clarity:
    • Line 71 should be: "The following example demonstrates how to ingest your GitHub repositories, their deployments and environments to Port, you may use the following Port blueprint definitions and port-app-config.yml:"
    • Line 83 should be: "The following example demonstrates how to ingest your GitHub repositories, their releases and tags to Port, you may use the following Port blueprint definitions and port-app-config.yml:"

📝 Specific Line-by-Line Issues

File Line Issue Fix
_github_exporter_example_environment_blueprint.mdx 2 Incorrect summary text Change "Deployment Environment blueprint" to "Environment blueprint"
_github_exporter_example_deployment_blueprint.mdx 24,28 "Running Service" terminology Change to "Environment" for consistency
_github_exporter_example_release_tag_port_app_config.mdx 3 Extra space in summary Remove space before "Port"
examples.md 71,83 Missing text clarity per review Update text as suggested by sivanel97

🎯 Technical Accuracy Assessment

Blueprint Configurations: All JSON blueprints follow proper Port schema structure
YAML Configurations: Port app configs use correct mapping syntax and relations
Resource Integration: Proper integration with existing components and imports
Live Events: Correctly updated to include deployment and release events

📋 CONTRIBUTING.md Compliance

Code Block Formatting: All code blocks properly include showLineNumbers (line 94)
Summary/Details Pattern: Uses correct <summary><b>Title (click to expand)</b></summary> format (lines 135-142)
Link Usage: Full path links used appropriately
Technical Writing: Clear, accurate, and complete information provided

💡 Recommendations

  1. Fix Summary Text Issues: Address the terminology inconsistencies for better clarity
  2. Update Examples.md: Implement sivanel97's suggested text improvements
  3. Standardize Terminology: Use "Environment" consistently instead of mixing with "Running Service"
  4. Test Configurations: Ensure YAML configs work with the provided blueprints in practice

Summary

This is a valuable addition to the documentation that provides comprehensive examples for GitHub Ocean integration. The main issues are minor formatting and terminology inconsistencies that should be addressed to ensure consistency and clarity for users.

Priority: Fix the summary text and terminology issues, then implement the text improvements suggested in the review comments.

Overall Assessment: ✅ Approve with minor changes requested


@sivanel97 sivanel97 merged commit b3749dc into main Aug 11, 2025
3 checks passed
@sivanel97 sivanel97 deleted the PORT-14552-deployment-environment-tags-releases branch August 11, 2025 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants