fix: update Polars selector type annotation to use Selector
#770
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Polars replaced `_selector_proxy_` with a public `Selector` class (pola-rs/polars#23351). This caused type checking imports to fail. This updates the type annotation import and alias accordingly.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #770 +/- ##
=======================================
Coverage 91.45% 91.45%
=======================================
Files 47 47
Lines 5558 5558
=======================================
Hits 5083 5083
Misses 475 475 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@rich-iannone and @machow, perhaps we should use a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a type annotation issue with Polars selectors.
Polars introduced a new
Selectorclass. As a result, the current import of_selector_proxy_ingreat-tablesfails when using at least version1.32.0of Polars.Without this change, type-checking
great-tableswith recent Polars versions fails due to missing_selector_proxy_.Changes
_selector_proxy_withSelectorPlSelectExpr = SelectorNotes
Selectoris available.Related GitHub Issues and PRs
Selectora concrete part of the DSL pola-rs/polars#23351Checklist
[ ] I have added pytest unit tests for any new functionality.