Skip to content

Fix multi-days-feed #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix multi-days-feed #86

wants to merge 1 commit into from

Conversation

1aristotelis
Copy link
Contributor

now should get the right amount of data into the multi day feed

@1aristotelis
Fix multi-days-feed
90b5c19 
now should get the right amount of data into the multi day feed
@1aristotelis 1aristotelis requested a review from stevenzeiler May 4, 2023 12:52
@stevenzeiler
Copy link
Contributor

I suspect this issue is deeper than this, and it also appears to me that your change will return only the first day of rankings.

@1aristotelis
Copy link
Contributor Author

1aristotelis commented May 4, 2023 •
edited
Loading

Unless im mistaken getCachedMultiDayFeed() returns an array of array of rankings for the past 7 days.
the query returns rankings which should be the ranking of the past day (it is not) and days which is an array of rankings in the past other days.
I don't see why i would be wrong on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stevenzeiler stevenzeiler Awaiting requested review from stevenzeiler

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@1aristotelis @stevenzeiler