CBMC: Improve proof stability #631
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthias J. Kannwischer <matthias@kannwischer.eu>
Signed-off-by: Matthias J. Kannwischer <matthias@kannwischer.eu>
Signed-off-by: Rod Chapman <rodchap@amazon.com>
mkannwischer
force-pushed
the
cbmc-stability2
branch
from
e8ad25b to
8696a93
Compare
mkannwischer
commented
Nov 6, 2025
to simplify polyvec_maxtrix_expand(), stabilize proof and avoid need to ignore code for proof. Signed-off-by: Rod Chapman <rodchap@amazon.com>
mkannwischer
force-pushed
the
cbmc-stability2
branch
from
ef71625 to
d346493
Compare
mkannwischer
commented
Nov 6, 2025
Contributor
Author
mkannwischer
left a comment
mkannwischer
left a comment
There was a problem hiding this comment.
This changes proof performance from
7 mins / 7 mins / 12 mins -> 6 mins / 6 mins / 8mins
Contributor
Author
|
I think this is good to merge. @hanno-becker, could you take a look, please? |
hanno-becker
reviewed
Nov 7, 2025
hanno-becker
reviewed
Nov 7, 2025
hanno-becker
approved these changes
Nov 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit hoists 4 of the 6 commits out of #611 to ease review.