Skip to content

Conversation

ajtejankar
Copy link
Contributor

This should prevent some nasty illegal memory access errors

  1. Consolidate individual list comprehensions into a single for loop
  2. Distinct code to create the lora weight pointers tensor
  3. Add test cases to test segments, indices, and weight pointers
  4. Add comments explaining the code in some tricky places

This should prevent some nasty illegal memory access errors

1. Consolidate individual list comprehensions into a single for loop
2. Distinct code to create the lora weight pointers tensor
3. Add test cases to test segments, indices, and weight pointers
4. Add comments explaining the code in some tricky places
@arnavgarg1 arnavgarg1 requested a review from tgaddair July 8, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant