Skip to content

Fix: call onUpdate on initial load #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jkebinger merged 1 commit into from
May 12, 2025
Merged

Fix: call onUpdate on initial load #105

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/prefab.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,6 @@ class Prefab implements PrefabInterface {
projectEnvId: ProjectEnvId,
defaultContext: Contexts
): void {
// Create resolver with a temporary no-op onUpdate for its construction phase
const tempResolver = new Resolver(
configs,
projectEnvId,
Expand All @@ -237,7 +236,6 @@ class Prefab implements PrefabInterface {

this.configChangeNotifier.init(tempResolver);

// Define the actual combined onUpdate callback
const actualCombinedOnUpdate = (
updatedConfigs: Array<Config | MinimumConfig>
): void => {
Expand All @@ -246,9 +244,11 @@ class Prefab implements PrefabInterface {
};

tempResolver.setOnUpdate(actualCombinedOnUpdate);

// Assign the fully configured resolver to the Prefab instance
this.resolver = tempResolver;

if (configs.length > 0) {
actualCombinedOnUpdate(configs);
}
}

async init({
Expand Down