Skip to content

Conversation

@mjfaga
Copy link
Contributor

@mjfaga mjfaga commented Jun 10, 2025

Description

Follow-up to 6fb3e3b to ensure we don't leverage the library to validate it's loaded. Instead, we now load the verifyPeerDependencies module first and blow up with a clean error before starting to execute code.

@mjfaga mjfaga force-pushed the mfaga-verify-peer-dependencies branch 5 times, most recently from 3dd5b56 to ff38aac Compare June 16, 2025 02:37
@mjfaga mjfaga force-pushed the mfaga-verify-peer-dependencies branch from ff38aac to 7691215 Compare June 16, 2025 02:40
@mjfaga mjfaga marked this pull request as ready for review June 16, 2025 02:41
@mjfaga mjfaga requested review from jdwyah and semanticart June 16, 2025 02:41
@jdwyah
Copy link
Contributor

jdwyah commented Jul 1, 2025

@semanticart can you weigh in on this? This feels clearer / safer, but also friction annoyance on install. And i presume that this will make existing users that haven't needed a peer dependency to start failing after they update prefab-cloud-node.

My understanding is that many folks don't actually need this peer dependency / that this only rears its heads on some platforms. But is that wrong? If everybody need peer long then we can just add it to the docs. I'm unclear what the best idea is if this is only necessary sometimes. Maybe it's this.

@mjfaga
Copy link
Contributor Author

mjfaga commented Jul 1, 2025

Happy to also consider wrapping the entire module and only executing that check if the dependency is actually need. It will be a bunch more code, but would be manageable. Alternatively, I could spend time investigating the original issue and try to figure out why the package fails in certain environments, and then we can avoid this altogether maybe?

@semanticart semanticart removed their request for review November 12, 2025 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants