Skip to content

Update stderr manipulation code in test helper #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jkebinger merged 2 commits into from
Feb 18, 2025
Merged

Update stderr manipulation code in test helper #225

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3fa00a8
Update stderr manipulation code in test helper
jkebinger Feb 14, 2025
8bb6291
put the restoration of std error back in assert_stderr
jkebinger Feb 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions test/support/common_helpers.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,14 +26,19 @@ def teardown
end
end

if $stderr != $oldstderr && !$stderr.string.empty?
#note this skips the output check in environments like rubymine that hijack the output. Alternative is a method missing error on string

if $stderr != $oldstderr && $stderr.respond_to?(:string) && !$stderr.string.empty?
# we ignore 2.X because of the number of `instance variable @xyz not initialized` warnings
if !RUBY_VERSION.start_with?('2.')
raise "Unexpected stderr. Handle stderr with assert_stderr\n\n#{$stderr.string}"
end
end

$stderr = $oldstderr
# Only restore stderr if we have a valid oldstderr
if $oldstderr
$stderr = $oldstderr
end

Timecop.return
end
Expand Down Expand Up @@ -174,6 +179,7 @@ def assert_logged(expected)
end

def assert_stderr(expected)
skip "Cannot verify stderr in current environment" unless $stderr.respond_to?(:string)
$stderr.string.split("\n").uniq.each do |line|
matched = false

Expand Down