Skip to content

Fix flappy test #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jkebinger merged 1 commit into from
Apr 15, 2025
Merged

Fix flappy test #230

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
138 changes: 69 additions & 69 deletions test/test_evaluation_summary_aggregator.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,86 +59,86 @@ def test_prepare_data
end

def test_sync
awhile_ago = Time.now - 60
now = Time.now
Timecop.freeze('2023-08-09 15:18:12 -0400') do
awhile_ago = Time.now - 60
now = Time.now

client = MockBaseClient.new
client = MockBaseClient.new

aggregator = nil
aggregator = nil

Timecop.freeze(awhile_ago) do
# start the aggregator in the past
aggregator = Prefab::EvaluationSummaryAggregator.new(client: client, max_keys: 10,
Timecop.freeze(awhile_ago) do
# start the aggregator in the past
aggregator = Prefab::EvaluationSummaryAggregator.new(client: client, max_keys: 10,
sync_interval: EFFECTIVELY_NEVER)
end

add_example_data(aggregator)
end

expected_post = PrefabProto::TelemetryEvents.new(
instance_hash: client.instance_hash,
events: [
PrefabProto::TelemetryEvent.new(
summaries:

PrefabProto::ConfigEvaluationSummaries.new(
start: awhile_ago.to_i * 1000,
end: now.to_i * 1000,
summaries: [
PrefabProto::ConfigEvaluationSummary.new(
key: 'config-1',
type: :CONFIG,
counters: [
PrefabProto::ConfigEvaluationCounter.new(
config_id: 1,
selected_index: 2,
config_row_index: 3,
conditional_value_index: 4,
weighted_value_index: 5,
selected_value: EXAMPLE_VALUE_1,
count: 3
),
PrefabProto::ConfigEvaluationCounter.new(
config_id: 1,
selected_index: 3,
config_row_index: 7,
conditional_value_index: 8,
weighted_value_index: 10,
selected_value: EXAMPLE_VALUE_2,
count: 1
)
]
),
PrefabProto::ConfigEvaluationSummary.new(
key: 'config-2',
type: :FEATURE_FLAG,
counters: [
PrefabProto::ConfigEvaluationCounter.new(
config_id: 2,
selected_index: 3,
config_row_index: 5,
conditional_value_index: 7,
weighted_value_index: 6,
selected_value: EXAMPLE_VALUE_1,
count: 9
)
]
add_example_data(aggregator)

expected_post = PrefabProto::TelemetryEvents.new(
instance_hash: client.instance_hash,
events: [
PrefabProto::TelemetryEvent.new(
summaries: PrefabProto::ConfigEvaluationSummaries.new(
start: awhile_ago.to_i * 1000,
end: now.to_i * 1000,
summaries: [
PrefabProto::ConfigEvaluationSummary.new(
key: 'config-1',
type: :CONFIG,
counters: [
PrefabProto::ConfigEvaluationCounter.new(
config_id: 1,
selected_index: 2,
config_row_index: 3,
conditional_value_index: 4,
weighted_value_index: 5,
selected_value: EXAMPLE_VALUE_1,
count: 3
),
PrefabProto::ConfigEvaluationCounter.new(
config_id: 1,
selected_index: 3,
config_row_index: 7,
conditional_value_index: 8,
weighted_value_index: 10,
selected_value: EXAMPLE_VALUE_2,
count: 1
)
]
),
PrefabProto::ConfigEvaluationSummary.new(
key: 'config-2',
type: :FEATURE_FLAG,
counters: [
PrefabProto::ConfigEvaluationCounter.new(
config_id: 2,
selected_index: 3,
config_row_index: 5,
conditional_value_index: 7,
weighted_value_index: 6,
selected_value: EXAMPLE_VALUE_1,
count: 9
)
]
)
]
)
)
]
)
)
]
)

requests = wait_for_post_requests(client) do
Timecop.freeze(now) do
aggregator.sync
requests = wait_for_post_requests(client) do
Timecop.freeze(now) do
aggregator.sync
end
end
end

assert_equal [[
'/api/v1/telemetry',
expected_post
]], requests
assert_equal [[
'/api/v1/telemetry',
expected_post
]], requests
end
end

private
Expand Down