Skip to content

args: allow_root default False #376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

args: allow_root default False #376

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ddc1a7f
args: allow_root default False
milahu Oct 12, 2021
01e7a0e
dont set args.allow_root
milahu Oct 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions gitfs/utils/args.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ def __init__(self, parser):
("foreground", (False, "bool")),
("branch", ("master", "string")),
("allow_other", (False, "bool")),
("allow_root", (True, "bool")),
("allow_root", (False, "bool")),
("commiter_name", (self.get_commiter_user, "string")),
("commiter_email", (self.get_commiter_email, "string")),
("max_size", (10, "float")),
Expand Down Expand Up @@ -76,12 +76,6 @@ def build_config(self, args):
return self.check_args(self.set_defaults(args))

def check_args(self, args):
# check allow_other and allow_root
if args.allow_other:
args.allow_root = False
else:
args.allow_root = True

# check log_level
if args.debug:
args.log_level = "debug"
Expand Down