[native] Add native session property native_disable_crc32_for_shuffle

[yingsu00]

Description

Add native session property native_disable_crc32_for_shuffle. When set to true, crc32c checksum computation and validation will be skipped when shuffling the data.

Release Notes

== RELEASE NOTES ==

General Changes
* Add native session property native_disable_crc32_for_shuffle. When set to true, crc32c checksum computation and validation will be skipped when shuffling the data

[sourcery-ai]

Reviewer's Guide

Introduce a new native session property native_disable_crc32_for_shuffle to skip CRC32C checksum during shuffle, wiring it through C++ session properties, the Java provider, QueryConfig, and tests. Additionally, revise CMakeLists to log build flags and disable spatial support by default.

Class diagram for updated SessionProperties with native_disable_crc32_for_shuffle

classDiagram
    class SessionProperties {
        +static constexpr const char* kDisableCrc32ForShuffle
        +SessionProperties()
        +static SessionProperties* instance()
    }
    SessionProperties : kDisableCrc32ForShuffle

Loading

Class diagram for updated NativeWorkerSessionPropertyProvider with native_disable_crc32_for_shuffle

classDiagram
    class NativeWorkerSessionPropertyProvider {
        +static final String NATIVE_DISABLE_CRC32_FOR_SHUFFLE
        +NativeWorkerSessionPropertyProvider(FeaturesConfig featuresConfig)
        -List<PropertyMetadata<?>> sessionProperties
    }
    NativeWorkerSessionPropertyProvider : NATIVE_DISABLE_CRC32_FOR_SHUFFLE

Loading

File-Level Changes

Change	Details	Files
Add native_disable_crc32_for_shuffle session property	Declare kDisableCrc32ForShuffle constant in SessionProperties.h Register property in SessionProperties constructor with default false Map to QueryConfig via toVeloxConfig Define constant and booleanProperty in Java provider Extend SessionPropertiesTest mapping with new property Verify disableCrc32ForShuffle flag in QueryContextManagerTest	presto-native-execution/presto_cpp/main/SessionProperties.h presto-native-execution/presto_cpp/main/SessionProperties.cpp presto-main-base/src/main/java/com/facebook/presto/sessionpropertyproviders/NativeWorkerSessionPropertyProvider.java presto-native-execution/presto_cpp/main/tests/SessionPropertiesTest.cpp presto-native-execution/presto_cpp/main/tests/QueryContextManagerTest.cpp
Update CMakeLists to improve flag logging and disable spatial support	Add status message for CMAKE_CXX_FLAGS Comment out address sanitizer flags placeholder Set PRESTO_ENABLE_SPATIAL OFF and expose VELOX_ENABLE_GEO Emit status message for VELOX_ENABLE_GEO	presto-native-execution/CMakeLists.txt

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.