Skip to content

chore(connector): Upgrade RoaringBitmap to 1.3.0 #26238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore(connector): Upgrade RoaringBitmap to 1.3.0 #26238

wants to merge 1 commit into from

Conversation

Mariamalmesfer
Copy link
Contributor

@Mariamalmesfer Mariamalmesfer commented Oct 6, 2025 •
edited
Loading

Description

Upgrade RoaringBitmap to 1.3.0

Motivation and Context

Impact

Test Plan

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== RELEASE NOTES ==

Security Changes
* Upgrade RoaringBitmap to 1.3.0.

@prestodb-ci prestodb-ci added the from:IBM PR from IBM label Oct 6, 2025
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Oct 6, 2025 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: Mariamalmesfer / name: Mariam AlMesfer (f956159)

@Mariamalmesfer Mariamalmesfer force-pushed the roaringbitmap-upgrade branch 2 times, most recently from deeeaf5 to 591dad8 Compare October 6, 2025 11:15
@steveburnett
Copy link
Contributor

Please add a release note to this PR. Thanks!

@Mariamalmesfer Mariamalmesfer changed the title Upgrade RoaringBitmap to latest version chore(connector): Upgrade RoaringBitmap to 1.3.0 Oct 6, 2025
@Mariamalmesfer Mariamalmesfer marked this pull request as ready for review October 6, 2025 21:59
@Mariamalmesfer Mariamalmesfer requested a review from a team as a code owner October 6, 2025 21:59
@prestodb-ci prestodb-ci requested review from a team, ScrapCodes and aaneja and removed request for a team October 6, 2025 21:59
agrawalreetika
agrawalreetika approved these changes Oct 7, 2025
View reviewed changes
Copy link
Member

@agrawalreetika agrawalreetika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it would be good to run some basic sanity test on pinot connector with the change to make sure its not breaking pinot connector query?

@Mariamalmesfer
Copy link
Contributor Author

Mariamalmesfer commented Oct 8, 2025 •
edited
Loading

LGTM, it would be good to run some basic sanity test on pinot connector with the change to make sure its not breaking pinot connector query?

@agrawalreetika Sure, I ran some queries, please check.
image
image
image
image

hantangwangd
hantangwangd approved these changes Oct 8, 2025
View reviewed changes
Copy link
Member

@hantangwangd hantangwangd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Mariamalmesfer

pratyakshsharma
pratyakshsharma approved these changes Oct 8, 2025
View reviewed changes
Copy link
Contributor

@pratyakshsharma pratyakshsharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agrawalreetika agrawalreetika agrawalreetika approved these changes

@hantangwangd hantangwangd hantangwangd approved these changes

@pratyakshsharma pratyakshsharma pratyakshsharma approved these changes

@ScrapCodes ScrapCodes Awaiting requested review from ScrapCodes ScrapCodes was automatically assigned from prestodb/ibm-reviewers

@aaneja aaneja Awaiting requested review from aaneja aaneja was automatically assigned from prestodb/ibm-reviewers

Assignees
No one assigned
Labels
from:IBM PR from IBM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Mariamalmesfer @steveburnett @agrawalreetika @hantangwangd @pratyakshsharma @prestodb-ci