Skip to content

Conversation

majetideepak
Copy link
Collaborator

@majetideepak majetideepak commented Oct 8, 2025

Description

After a recent change #25855, the Watchdog fails to run if the hardware_concurrency() returns an odd number.
The root cause is that 0.5 * hardwareConcurrency() fails to cast to a size_t

Motivation and Context

Impact

Test Plan

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.
== NO RELEASE NOTE ==

@majetideepak majetideepak requested review from a team as code owners October 8, 2025 20:48
@prestodb-ci prestodb-ci added the from:IBM PR from IBM label Oct 8, 2025
@prestodb-ci prestodb-ci requested review from a team, anandamideShakyan and nmahadevuni and removed request for a team October 8, 2025 20:48
Copy link
Contributor

sourcery-ai bot commented Oct 8, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Ensure the default number of stuck operators to detach uses rounded half of hardware threads instead of truncating, fixing failures when hardware_concurrency() returns odd values.

Class diagram for updated SystemConfig initialization

classDiagram
    class SystemConfig {
        +SystemConfig()
        -NUM_PROP(kDriverNumStuckOperatorsToDetachWorker, value)
    }
    SystemConfig : NUM_PROP(kDriverNumStuckOperatorsToDetachWorker, std::round(0.5 * hardwareConcurrency()))
Loading

File-Level Changes

Change Details Files
Compute half of hardware concurrency with rounding instead of implicit truncation
  • Replace 0.5 * hardwareConcurrency() with std::round(0.5 * hardwareConcurrency()) in the NUM_PROP invocation
presto-native-execution/presto_cpp/main/common/Configs.cpp

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@majetideepak majetideepak requested review from amitkdutta, spershin and tanjialiang and removed request for anandamideShakyan and nmahadevuni October 8, 2025 20:49
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@majetideepak
Copy link
Collaborator Author

@amitkdutta, @aditi-pandit Can you please look?

Copy link
Contributor

@amitkdutta amitkdutta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @majetideepak

@majetideepak majetideepak merged commit f81a14c into prestodb:master Oct 9, 2025
95 of 100 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

from:IBM PR from IBM

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants