-
Notifications
You must be signed in to change notification settings - Fork 5.5k
fix(native): Watchdog fails to run on certain setups #26255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideEnsure the default number of stuck operators to detach uses rounded half of hardware threads instead of truncating, fixing failures when hardware_concurrency() returns odd values. Class diagram for updated SystemConfig initializationclassDiagram
class SystemConfig {
+SystemConfig()
-NUM_PROP(kDriverNumStuckOperatorsToDetachWorker, value)
}
SystemConfig : NUM_PROP(kDriverNumStuckOperatorsToDetachWorker, std::round(0.5 * hardwareConcurrency()))
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@amitkdutta, @aditi-pandit Can you please look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @majetideepak
Description
After a recent change #25855, the Watchdog fails to run if the hardware_concurrency() returns an odd number.
The root cause is that
0.5 * hardwareConcurrency()
fails to cast to asize_t
Motivation and Context
Impact
Test Plan
Contributor checklist