Skip to content

Conversation

zacw7
Copy link
Member

@zacw7 zacw7 commented Oct 9, 2025

== NO RELEASE NOTE ==

@prestodb-ci prestodb-ci added the from:Meta PR from Meta label Oct 9, 2025
Copy link
Contributor

sourcery-ai bot commented Oct 9, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Fixes a typo in the session property rewriter flag by renaming the method and updating its usage for rewriting constant array contains-to-IN expressions.

Class diagram for SystemSessionProperties method rename

classDiagram
class SystemSessionProperties {
  +isPullExpressionFromLambdaEnabled(Session): boolean
  -isRwriteConstantArrayContainsToInExpressionEnabled(Session): boolean
  +isRewriteConstantArrayContainsToInExpressionEnabled(Session): boolean
}
Loading

File-Level Changes

Change Details Files
Corrected the typo in the rewriter enablement method and its invocation
  • Renamed isRwriteConstantArrayContainsToInExpressionEnabled to isRewriteConstantArrayContainsToInExpressionEnabled
  • Updated isRewriterEnabled() to call the renamed method
presto-main-base/src/main/java/com/facebook/presto/SystemSessionProperties.java
presto-main-base/src/main/java/com/facebook/presto/sql/planner/iterative/rule/RewriteConstantArrayContainsToInExpression.java

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@zacw7 zacw7 requested review from feilong-liu and xiaoxmeng October 9, 2025 04:17
@zacw7 zacw7 changed the title Fix a typo rwrite to rewrite fix: change typo rwrite to rewrite Oct 9, 2025
@zacw7 zacw7 changed the title fix: change typo rwrite to rewrite fix: Change typo rwrite to rewrite Oct 9, 2025
@zacw7 zacw7 marked this pull request as ready for review October 9, 2025 04:34
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@zacw7 zacw7 merged commit a9f03d8 into prestodb:master Oct 9, 2025
107 of 108 checks passed
@zacw7 zacw7 deleted the typo-rwrite branch October 9, 2025 19:13
imsayari404 pushed a commit to imsayari404/presto that referenced this pull request Oct 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

from:Meta PR from Meta

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants