Skip to content

Conversation

steveburnett
Copy link
Contributor

@steveburnett steveburnett commented Oct 9, 2025

Description

Add a clarifying note to the description of iceberg.compression-codec in Configuration Properties in connector/iceberg.rst about what compression codecs are available in a specific file format.

Motivation and Context

Fixes #26261.

Impact

Documentation.

Test Plan

Local doc build. See screenshot:
Screenshot 2025-10-09 at 2 42 06 PM

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

== NO RELEASE NOTE ==

@prestodb-ci prestodb-ci added the from:IBM PR from IBM label Oct 9, 2025
@prestodb-ci prestodb-ci requested review from a team, NivinCS and jp-sivaprasad and removed request for a team October 9, 2025 18:49
Copy link
Contributor

sourcery-ai bot commented Oct 9, 2025

🧙 Sourcery has finished reviewing your pull request!


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@steveburnett steveburnett self-assigned this Oct 9, 2025
@github-project-automation github-project-automation bot moved this to 🆕 Unprioritized in Presto Documentation Oct 9, 2025
@steveburnett steveburnett moved this from 🆕 Unprioritized to 👀 Review in Presto Documentation Oct 9, 2025
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Contributor

@PingLiuPing PingLiuPing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

PingLiuPing
PingLiuPing previously approved these changes Oct 10, 2025
@steveburnett steveburnett force-pushed the steveburnett-iceberg-compression2 branch from 6ad3969 to f0c8706 Compare October 14, 2025 19:29
@github-project-automation github-project-automation bot moved this from 👀 Review to ✅ Done in Presto Documentation Oct 14, 2025
@hantangwangd
Copy link
Member

Thanks for the update, lgtm!

@hantangwangd hantangwangd merged commit eb38723 into prestodb:master Oct 16, 2025
73 checks passed
@hantangwangd
Copy link
Member

@steveburnett @agrawalreetika I've create an issue #26334 to track the future compression codec support. After checking with @ZacBlanco, he's happy to help review but probably do not have enough time to take PR #25021 all the way to merge. Will fork his work in #25021 into a new PR and drive it from there soon.

@steveburnett
Copy link
Contributor Author

@steveburnett @agrawalreetika I've create an issue #26334 to track the future compression codec support. After checking with @ZacBlanco, he's happy to help review but probably do not have enough time to take PR #25021 all the way to merge. Will fork his work in #25021 into a new PR and drive it from there soon.

Thank you @hantangwangd!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs from:IBM PR from IBM

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Iceberg configuration properties 'iceberg.compression-codec description is inaccurate

5 participants