Add knip #1305
Merged
Add knip #1305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fvictorio
commented
Nov 8, 2025
| "ignoreFiles": [ | ||
| "tests/format/RespectDefaultOptions/respect-default-options.js", | ||
| "tests/integration/node.test.js" | ||
| ], |
Member
Author
There was a problem hiding this comment.
The difference between ignore and ignoreFiles is not super obvious:
ignoremeans "don't report unused code inside this file".ignoreFilesmeans "don't report the whole file as unused"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds knip, a tool to find unused code. I've used in a couple of projects and it works quite well.
The most important thing to review here are the files I'm adding to the
ignore*fields in theknip.jsonconfig. I'm erring on the side of not deleting things, since I don't know whether they are used or not.I also added
npm run knipto thelintscript. Knip is quite fast, so this shouldn't make that script much slower. But if you think this is annoying, we can change that and only run it in the CI.I'm creating this PR on top of #1296, since that's the last big refactor.