Skip to content

remove unused contrast from Select component #6272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Sep 4, 2025
Merged

remove unused contrast from Select component #6272

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
41a1637
remove contrast from Select component
llastflowers Jul 2, 2025
b222620
Create dirty-chairs-invent.md
llastflowers Jul 2, 2025
b5032d1
also omit contrast from StyledWrapperProps
llastflowers Jul 3, 2025
9af3b8d
Merge branch 'main' into llastflowers/5307/Select-remove-contrast
llastflowers Jul 3, 2025
6cf50f0
Create brown-pugs-rescue.md
llastflowers Jul 3, 2025
074a0cd
Update dirty-chairs-invent.md
llastflowers Jul 3, 2025
ef24d65
Delete .changeset/brown-pugs-rescue.md
llastflowers Jul 3, 2025
4ad3356
Merge branch 'main' into llastflowers/5307/Select-remove-contrast
llastflowers Jul 30, 2025
30872f6
Merge branch 'main' into llastflowers/5307/Select-remove-contrast
llastflowers Sep 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/dirty-chairs-invent.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/react": major
---

remove unused `contrast` from Select component
4 changes: 1 addition & 3 deletions packages/react/src/Select/Select.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import type {ForwardRefComponent as PolymorphicForwardRefComponent} from '../uti
import classes from './Select.module.css'

export type SelectProps = Omit<
Omit<React.ComponentProps<'select'>, 'size'> & Omit<StyledWrapperProps, 'variant'>,
Omit<React.ComponentProps<'select'>, 'size'> & Omit<StyledWrapperProps, 'variant' | 'contrast'>,
'multiple' | 'hasLeadingVisual' | 'hasTrailingVisual' | 'as'
> & {
placeholder?: string
Expand Down Expand Up @@ -38,7 +38,6 @@ const Select = React.forwardRef<HTMLSelectElement, SelectProps>(
block,
children,
className,
contrast,
defaultValue,
disabled,
placeholder,
Expand All @@ -53,7 +52,6 @@ const Select = React.forwardRef<HTMLSelectElement, SelectProps>(
return (
<TextInputWrapper
block={block}
contrast={contrast}
disabled={disabled}
size={size}
validationStatus={validationStatus}
Expand Down
Loading