-
Notifications
You must be signed in to change notification settings - Fork 625
Revert "Clean up the feature flag for primer_react_segmented_control_tooltip
"
#6412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…_tooltip…" This reverts commit 210aaa6.
|
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
size-limit report 📦
|
👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/393310 |
🟢 golden-jobs completed with status |
FYI @khiga8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR reverts a previous change that cleaned up the feature flag for primer_react_segmented_control_tooltip
due to integration check failures. The revert restores the feature flag gating mechanism for tooltip functionality in SegmentedControl icon buttons.
- Re-adds the
primer_react_segmented_control_tooltip
feature flag with default valuefalse
- Restores conditional rendering logic in SegmentedControlIconButton based on the feature flag
- Updates tests to properly handle both enabled and disabled feature flag states
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
packages/react/src/SegmentedControl/SegmentedControlIconButton.tsx | Restores feature flag conditional logic and fallback rendering without tooltip |
packages/react/src/SegmentedControl/SegmentedControl.test.tsx | Updates tests to wrap tooltip tests with FeatureFlags provider and adds test for disabled state |
packages/react/src/FeatureFlags/DefaultFeatureFlags.ts | Re-adds the primer_react_segmented_control_tooltip feature flag set to false |
.changeset/strong-mangos-rest.md | Removes the changeset entry for the reverted feature |
</BoxWithFallback> | ||
) | ||
} else { | ||
// This can be removed when primer_react_segmented_control_tooltip feature flag is GA-ed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider adding a TODO comment with a ticket reference or target date for when this fallback code should be removed to help track technical debt.
// This can be removed when primer_react_segmented_control_tooltip feature flag is GA-ed. | |
// TODO: Remove this fallback code when primer_react_segmented_control_tooltip feature flag is GA-ed. | |
// Tracking issue: [INSERT_TICKET_REFERENCE_HERE] |
Copilot uses AI. Check for mistakes.
Reverts #6307
This PR broke integration checks, so taking out of the release