Skip to content

Revert "Clean up the feature flag for primer_react_segmented_control_tooltip" #6412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 29, 2025

Conversation

francinelucca
Copy link
Member

@francinelucca francinelucca commented Jul 29, 2025

Reverts #6307

This PR broke integration checks, so taking out of the release

Copy link

changeset-bot bot commented Jul 29, 2025

⚠️ No Changeset found

Latest commit: d040ec8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added staff Author is a staff member integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Jul 29, 2025
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

Copy link
Contributor

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 92.27 KB (+0.08% 🔺)
packages/react/dist/browser.umd.js 92.44 KB (-0.12% 🔽)

@primer-integration
Copy link

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/393310

@primer-integration
Copy link

🟢 golden-jobs completed with status success.

@github-actions github-actions bot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Jul 29, 2025
@francinelucca francinelucca marked this pull request as ready for review July 29, 2025 04:34
@Copilot Copilot AI review requested due to automatic review settings July 29, 2025 04:34
@francinelucca francinelucca requested a review from a team as a code owner July 29, 2025 04:34
@francinelucca francinelucca requested a review from joshblack July 29, 2025 04:34
@francinelucca
Copy link
Member Author

FYI @khiga8

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reverts a previous change that cleaned up the feature flag for primer_react_segmented_control_tooltip due to integration check failures. The revert restores the feature flag gating mechanism for tooltip functionality in SegmentedControl icon buttons.

  • Re-adds the primer_react_segmented_control_tooltip feature flag with default value false
  • Restores conditional rendering logic in SegmentedControlIconButton based on the feature flag
  • Updates tests to properly handle both enabled and disabled feature flag states

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
packages/react/src/SegmentedControl/SegmentedControlIconButton.tsx Restores feature flag conditional logic and fallback rendering without tooltip
packages/react/src/SegmentedControl/SegmentedControl.test.tsx Updates tests to wrap tooltip tests with FeatureFlags provider and adds test for disabled state
packages/react/src/FeatureFlags/DefaultFeatureFlags.ts Re-adds the primer_react_segmented_control_tooltip feature flag set to false
.changeset/strong-mangos-rest.md Removes the changeset entry for the reverted feature

</BoxWithFallback>
)
} else {
// This can be removed when primer_react_segmented_control_tooltip feature flag is GA-ed.
Copy link
Preview

Copilot AI Jul 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding a TODO comment with a ticket reference or target date for when this fallback code should be removed to help track technical debt.

Suggested change
// This can be removed when primer_react_segmented_control_tooltip feature flag is GA-ed.
// TODO: Remove this fallback code when primer_react_segmented_control_tooltip feature flag is GA-ed.
// Tracking issue: [INSERT_TICKET_REFERENCE_HERE]

Copilot uses AI. Check for mistakes.

@francinelucca francinelucca added this pull request to the merge queue Jul 29, 2025
Merged via the queue into main with commit 602b29a Jul 29, 2025
48 checks passed
@francinelucca francinelucca deleted the revert-6307-kh-remove-feature-flag branch July 29, 2025 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh staff Author is a staff member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants