-
Notifications
You must be signed in to change notification settings - Fork 868
DR-6377 | Update Next.js Guide #7396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Dangerous URL checkNo absolute URLs to prisma.io/docs found. |
WalkthroughThis PR revises the Next.js integration guide: removes explicit "Next.js 15" references from title/introduction, broadens Node.js prerequisite ranges, clarifies that Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Pre-merge checks❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Redirect checkThis PR probably requires the following redirects to be added to static/_redirects:
|
Deploying docs with
|
| Latest commit: |
046320e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://cd60de97.docs-51g.pages.dev |
| Branch Preview URL: | https://dr-6377-update-nextjs-guide.docs-51g.pages.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
content/800-guides/090-nextjs.mdx (1)
253-275: Fix"script"→"scripts"in both JSON examples (lines 255, 267).The JSON key in
package.jsonmust be"scripts"(plural), not"script"(singular). Both code blocks contain this typo and will produce invalid configuration if users copy them directly. Apply this fix to both the Next.js 15.2.x and 16+ examples.
🧹 Nitpick comments (1)
content/800-guides/090-nextjs.mdx (1)
684-695: Potential inconsistency with version-specific Turbopack guidance.The
package.jsonexample here shows"dev": "next dev --turbopack"(line 690), but the earlier warning block (lines 253-275) provides version-specific guidance:
- Next.js 15.2.0/15.2.1: Remove
--turbopack- Next.js 16+:
--turbopackflag is no longer usedConsider adding a comment or note indicating users should adjust this based on their Next.js version, or reference the earlier guidance to avoid confusion.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
content/800-guides/090-nextjs.mdx(5 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Check internal links
- GitHub Check: Cloudflare Pages
🔇 Additional comments (4)
content/800-guides/090-nextjs.mdx (4)
2-3: LGTM — version-agnostic title is a good improvement.Removing the hardcoded Next.js version from the title makes this guide more maintainable over time. Users won't be confused when new Next.js versions are released.
25-25: LGTM — consistent with the version-agnostic approach.
95-96: Good clarification on directory creation timing.This addition helps prevent user confusion about why the
app/generated/prismadirectory doesn't exist immediately after runningprisma init. Clear expectation-setting like this reduces friction for newcomers.
30-30: Node.js v24 is available; update requirements reflect current LTS lines.The specific version thresholds (v20.19+, v22.12+, v24.0+) are helpful for users. However, since Node.js 24 was released in April 2025, the concern about availability is outdated. These version requirements accurately target the minimum stable releases across Node.js's current LTS release lines and are appropriate for Next.js documentation.
🍈 Lychee Link Check Report
📊 Results Overview
Errors per inputErrors in 200-orm/050-overview/100-introduction/200-why-prisma.mdx
|
🍈 Lychee Link Check Report
📊 Results Overview
Errors per inputErrors in 200-orm/050-overview/500-databases/840-cockroachdb.mdx
Errors in 200-orm/200-prisma-client/500-deployment/201-serverless/500-deploy-to-netlify.mdx
Errors in 200-orm/800-more/350-ai-tools/100-cursor.mdx
Errors in 800-guides/380-vercel-app-deployment.mdx
|
🍈 Lychee Link Check Report
📊 Results Overview
Errors per inputErrors in 200-orm/050-overview/500-databases/840-cockroachdb.mdx
Errors in 200-orm/800-more/350-ai-tools/100-cursor.mdx
Errors in 800-guides/380-vercel-app-deployment.mdx
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
content/800-guides/090-nextjs.mdx (1)
175-228: Add error handling and cleanup to the seed script.The seed script is missing proper error handling and database connection cleanup. When
main()is called on line 227, errors could be silently swallowed, and the Prisma Client connection won't be properly closed.🔎 Proposed fix to add error handling and cleanup
export async function main() { for (const u of userData) { await prisma.user.create({ data: u }); } } -main(); +main() + .then(async () => { + await prisma.$disconnect() + }) + .catch(async (e) => { + console.error(e) + await prisma.$disconnect() + process.exit(1) + })
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
content/800-guides/090-nextjs.mdx
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Check internal links
- GitHub Check: Cloudflare Pages
🔇 Additional comments (5)
content/800-guides/090-nextjs.mdx (5)
3-3: Good change to make the guide version-agnostic.Removing the specific version reference from the metaTitle helps keep the guide relevant across Next.js versions without requiring frequent updates.
25-25: Appropriate generalization of the introduction.Removing the explicit "Next.js 15" reference makes the guide more maintainable and applicable to current and future Next.js versions.
92-96: Excellent clarification about directory creation timing.This addition helps set proper expectations for users by explaining when the output directory will actually be created. This prevents potential confusion when the directory doesn't exist immediately after initialization.
230-248: Seed configuration is correctly structured.The addition of the seed configuration to
prisma.config.tsproperly integrates the seed script with Prisma's CLI, allowing users to runnpx prisma db seedas documented.
169-262: Well-structured seeding instructions.The seeding section provides clear, step-by-step guidance with proper commands and helpful verification steps using Prisma Studio. The flow is logical and easy to follow.
🍈 Lychee Link Check Report
📊 Results Overview
Errors per inputErrors in 200-orm/050-overview/500-databases/840-cockroachdb.mdx
Errors in 200-orm/800-more/350-ai-tools/100-cursor.mdx
Errors in 800-guides/380-vercel-app-deployment.mdx
|
🍈 Lychee Link Check Report
📊 Results Overview
Errors per inputErrors in 200-orm/050-overview/500-databases/840-cockroachdb.mdx
Errors in 200-orm/800-more/350-ai-tools/100-cursor.mdx
Errors in 800-guides/380-vercel-app-deployment.mdx
|
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.