-
Notifications
You must be signed in to change notification settings - Fork 870
docs: highlight Prisma 7 driver adapter pool defaults and add v6 parity examples #7406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: highlight Prisma 7 driver adapter pool defaults and add v6 parity examples #7406
Conversation
WalkthroughUpdates documentation across database driver files and upgrade guide to replace tips with warnings about Prisma v7 connection pooling defaults. Adds configuration examples demonstrating how to align driver adapters (pg, mariadb, mssql) with v6 timeout behavior. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
Pre-merge checks✅ Passed checks (3 passed)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (5)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
🔇 Additional comments (7)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Dangerous URL checkNo absolute URLs to prisma.io/docs found. |
Redirect checkThis PR probably requires the following redirects to be added to static/_redirects:
|
🍈 Lychee Link Check Report
📊 Results Overview
Errors per inputErrors in 200-orm/800-more/350-ai-tools/100-cursor.mdx
Errors in 800-guides/380-vercel-app-deployment.mdx
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
content/200-orm/050-overview/500-databases/800-sql-server/index.mdx (1)
51-51: Critical typo: "SQLite" should be "SQL Server"This line incorrectly states "For SQLite" when the section is about SQL Server and the
mssqldriver. This will confuse readers.🔎 Proposed fix
-For SQLite, [`node-mssql`](https://github.com/tediousjs/node-mssql) is one of the most popular drivers in the JavaScript ecosystem. +For SQL Server, [`node-mssql`](https://github.com/tediousjs/node-mssql) is one of the most popular drivers in the JavaScript ecosystem.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
content/200-orm/050-overview/500-databases/300-postgresql.mdxcontent/200-orm/050-overview/500-databases/400-mysql.mdxcontent/200-orm/050-overview/500-databases/800-sql-server/index.mdxcontent/200-orm/200-prisma-client/000-setup-and-configuration/050-databases-connections/115-connection-pool.mdxcontent/200-orm/800-more/300-upgrade-guides/200-upgrading-versions/400-upgrading-to-prisma-7.mdx
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Check internal links
- GitHub Check: Cloudflare Pages
🔇 Additional comments (7)
content/200-orm/050-overview/500-databases/800-sql-server/index.mdx (1)
134-143: Clear warning about v7 pool defaultsThe warning effectively highlights the breaking change with specific default values and provides clear remediation guidance. The link to the detailed configuration guide is helpful for users experiencing timeout issues.
content/200-orm/200-prisma-client/000-setup-and-configuration/050-databases-connections/115-connection-pool.mdx (3)
59-75: Well-structured example for PostgreSQL v6 parityThe example clearly demonstrates how to configure the
pgdriver adapter to match Prisma v6 timeout behavior. The code is complete and the comments clearly map v6 parameters to v7 fields.
92-112: Excellent note about unit differencesThe example correctly configures MariaDB timeout settings, and the inline comment on line 108 appropriately highlights that
idleTimeoutis in seconds (not milliseconds), preventing a common configuration mistake.
128-150: Complete mssql configuration exampleThe example properly shows nested pool configuration and correctly translates v6 defaults to the mssql driver's structure. The timeout values are accurate.
content/200-orm/050-overview/500-databases/300-postgresql.mdx (1)
163-172: Consistent warning messaging across database connectorsThe warning effectively communicates the v7 breaking change with specific default values. The upgrade from "tip" to "warning" appropriately reflects the severity of this change for users migrating from v6.
content/200-orm/800-more/300-upgrade-guides/200-upgrading-versions/400-upgrading-to-prisma-7.mdx (1)
178-184: Important upgrade guidance positioned effectivelyThis warning is well-placed in the driver adapters section of the upgrade guide. The concrete pg example helps users understand the impact, and the link to detailed configuration examples provides a clear path to resolution.
content/200-orm/050-overview/500-databases/400-mysql.mdx (1)
133-142: Comprehensive warning with accurate defaultsThe warning clearly communicates the mariadb driver's default differences from v6. The specific timeout values help users diagnose issues, and the targeted link to the mariadb-specific section of the connection pool guide streamlines the resolution process.
Deploying docs with
|
| Latest commit: |
d42c289
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://db2cf38b.docs-51g.pages.dev |
| Branch Preview URL: | https://dr-6388-make-the-connection.docs-51g.pages.dev |
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.