Solves Issue 7975 #8025
Open
Solves Issue 7975 #8025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced modifyMaterialShader, modifyFilterShader, modifyNormalShader, modifyColorShader, and modifyStrokeShader functions - Added documentation file 'modifymethod shortcut.md' explaining usage and benefits
ksen0
reviewed
Aug 8, 2025
| with: | ||
| script: | | ||
| const prBody = context.payload.pull_request.body; | ||
| const issueRegex = /(Fixes|Resolves|Closes)\s+#(\d+)/gi; |
There was a problem hiding this comment.
Minor: consider making more flexible? Eg /(close[sd]?|fix(e[sd])?|resolve[sd]?)[:\s]*#(\d+)/gi or something like that to more match the level of flexibility that happens on the main branch. While this is a bit more complex, I think matching behavior between these branches might be worth doing, what do you thi nk @perminder-17 ?
|
|
||
| jobs: | ||
| close_issues: | ||
| if: github.event.pull_request.merged == true |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #7989
Changes:
Added a yaml file which listens for maintainers comments to close and merge pul request.
Screenshots of the change:
I was cleaning up my local git branch and accidentally deleted the branch I was using for testing, so the original pull request also got deleted.
Hence again opening the pull request.
PR Checklist
npm run lintpasses