SketchException refactor #1164
Draft
SketchException refactor #1164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes bug with selecting an error that's in a tab that isn't visible yet.
…ls.SketchException, except I'm missing something because on compile it's not finding it. (module / package visibility problem or somethin')
…s for now though(?)
|
uhhhh just noticed this PR is re-including commits for the previous bug fix I did. is that a problem, other than being kind of ugly? |
|
(Also, I can do some more testing yet, but wanted to check that the merge timing made sense and to ask about the other modes) ((also I like parentheticals too much and am probably overthinking what to say, ha ha)) |
3 tasks
Stefterv
reviewed
Jul 23, 2025
There was a problem hiding this comment.
Hi @joshgiesbrecht Sorry it took me so long to take a good look at this. Thank you for taking this on and fixing this issue!
Looks good to me, I added a few comments that are mostly about style.
| id("java") | ||
| } | ||
|
|
||
| group = "org.example" |
| @@ -1,2 +1,3 @@ | |||
| bin | |||
| pde.jar | |||
| /utils/build/ | |||
There was a problem hiding this comment.
Please use the top level .gitignore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created an
:app:utilsmodule, movedSketchExceptionto aprocessing.utilspackage within:app:utils, changed all references toSketchExceptionin bothjavaandappto useprocessing.utils.SketchException, removed the two duplicateSketchExceptionclasses inappandjava.preproc.This currently seems to work (tested only on Linux so far, but I don't think there's anything platform-specific involved), and does solve the bug of highlighting the first error on running a sketch. Non-Java modes will not yet be using the correct SketchException class; I suspect this will be a 'soft' fail that has a similar problem to the existing bug, but I haven't tested this much yet. (Shader mode seems to be broken already?)
Since the draft PR for #1104 also creates
:app:utilsand is more complex than this PR, I'm fine with waiting until the other PR is merged, and then I can make sure this one merges cleanly before it's added in.What's the right thing to do re: the impact on non-Java modes? Should I submit PRs for those projects as well, maybe once this one's actually merged into main?