[WIP] SpaceScreen, SpaceLobby, space-only mode in RoomsList, etc #636
+853
−168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
showing SpaceLobby entry in the RoomsList, etc. SpaceLobby itself not yet impl'd. Full usage of `SelectedRoom::Space` not yet impl'd.
Still need to add: 1. Filtering displayed rooms in `RoomsList::update_displayed_rooms()`, 2. Saving desktop dock state, and closing rooms not in the selected space, 3. Restoring desktop dock state upon going back to the home tab, 4. Fleshing out the SpaceLobbyScreen
Fix text in SpacesBar to be more accurate regarding whether the displayed spaces are all joined spaces or just those that match the currently-entered keyword(s) in the RoomFilterInputBar.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
showing SpaceLobby entry in the RoomsList, etc.
SpaceLobby itself not yet impl'd.
Full usage of
SelectedRoom::Spacenot yet impl'd.