diskstats: add fallback to ID_SERIAL for virtio devices #3398
+15
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
illustris
force-pushed
the
virtio-serial
branch
from
556c362 to
2fff0ec
Compare
Virtio devices don't have ID_SERIAL_SHORT but do have ID_SERIAL. This change adds a fallback to use ID_SERIAL when ID_SERIAL_SHORT is not available, allowing serial numbers to be properly exposed for virtio block devices. Also updates test expectations to reflect that devices with only ID_SERIAL (like mmcblk devices in fixtures) now report their serial numbers instead of empty strings. Signed-off-by: illustris <rharikrishnan95@gmail.com>
illustris
force-pushed
the
virtio-serial
branch
from
2fff0ec to
c22be9a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Virtio devices don't have ID_SERIAL_SHORT but do have ID_SERIAL. For example:
This change adds a fallback to use ID_SERIAL when ID_SERIAL_SHORT is not available.