Skip to content

chore(webui): Metrics filtering improvements #4977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

will-holley
Copy link
Contributor

@will-holley will-holley commented Jul 17, 2025

  • Don't show metrics selector unless there are >1 metrics to filter by
  • Fixes incorrect metric result "X out of Y" counts (X is the number of rows while Y is calculated by the number of test cases * prompts)

Copy link
Contributor

use-tusk bot commented Jul 17, 2025

✅ Generated 2 tests - 2 passed (70253a3) View tests ↗

View output in GitHub ↗

Test Summary

  • ResultsView - 2 ✅

Results

Tusk's tests validate the updated metrics filtering logic in the PR. Both tests pass, confirming that the MetricFilterSelector is correctly hidden when only one metric is available, while still showing the FiltersButton when multi-metric filtering is enabled. This ensures the UI remains clean by removing unnecessary controls when they don't provide value.

Key points:

  • Tests cover the core UI behavior change in ResultsView component
  • Validates both standard and feature-flag enabled paths
  • Confirms we're not showing useless UI elements to users when there's only one metric
  • Important for UX since this component is on the main evaluation results page
  • Edge case with feature flag + single metric is properly handled
View check history

Commit Status Output Created (UTC)
d17a643 ✅ Generated 2 tests - 2 passed Tests Jul 17, 2025 10:10PM
70253a3 ✅ Generated 2 tests - 2 passed Tests Jul 18, 2025 7:20PM

Was Tusk helpful? Give feedback by reacting with 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant