Skip to content

Adding removal_errors to feature_support that has edition_removed. This is now a requirement new parser change (cl/838888348) #24713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
copybara-service wants to merge 1 commit into from
Closed

Adding removal_errors to feature_support that has edition_removed. This is now a requirement new parser change (cl/838888348) #24713

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/google/protobuf/unittest_custom_features.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ enum ValueLifetimeFeature {
edition_deprecated: EDITION_99998_TEST_ONLY
deprecation_warning: "Custom feature deprecation warning"
edition_removed: EDITION_99999_TEST_ONLY
removal_error: "Custom feature removal error"
}];
VALUE_LIFETIME_EMPTY_SUPPORT = 3 [feature_support = {}];
VALUE_LIFETIME_FUTURE = 4
Expand All @@ -60,6 +61,7 @@ enum ValueLifetimeFeature {
}];
VALUE_LIFETIME_REMOVED = 6 [feature_support = {
edition_deprecated: EDITION_2023
deprecation_warning: "Custom feature deprecation warning"
edition_removed: EDITION_99997_TEST_ONLY
removal_error: "Custom feature removal error"
}];
Expand Down Expand Up @@ -202,6 +204,7 @@ message TestCustomFeatures {
feature_support = {
edition_introduced: EDITION_2023
edition_removed: EDITION_2023
removal_error: "Custom feature removal error"
},
edition_defaults = { edition: EDITION_LEGACY, value: "VALUE1" }
];
Expand Down
3 changes: 3 additions & 0 deletions src/google/protobuf/unittest_features.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ enum ValueLifetimeFeature {
edition_deprecated: EDITION_99998_TEST_ONLY
deprecation_warning: "Custom feature deprecation warning"
edition_removed: EDITION_99999_TEST_ONLY
removal_error: "Custom feature removal error"
}];
VALUE_LIFETIME_EMPTY_SUPPORT = 3 [feature_support = {}];
VALUE_LIFETIME_FUTURE = 4
Expand All @@ -73,6 +74,7 @@ enum ValueLifetimeFeature {
}];
VALUE_LIFETIME_REMOVED = 6 [feature_support = {
edition_deprecated: EDITION_2023
deprecation_warning: "Custom feature deprecation warning"
edition_removed: EDITION_99997_TEST_ONLY
removal_error: "Custom feature removal error"
}];
Expand Down Expand Up @@ -240,6 +242,7 @@ message TestFeatures {
feature_support = {
edition_introduced: EDITION_2023
edition_removed: EDITION_2023
removal_error: "Custom feature removal error"
},
edition_defaults = { edition: EDITION_LEGACY, value: "VALUE1" }
];
Expand Down
Loading