fix: enable dependency uploads without login #63
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kacperklosowski
had a problem deploying
to
integration
GitHub Actions
Failure
|
Great finding @kacperklosowski - feel free to include basic rate limit for the endpoint and we'll be good to go. |
|
@psmyrdek rate limiting was added (as proposed in PR - 1 upload every 5s) :) |
|
@all-contributors add @kacperklosowski for code |
|
I've put up a pull request to add @kacperklosowski! 🎉 |
kacperklosowski
had a problem deploying
to
integration
GitHub Actions
Failure
|
GJ |
|
Hi @psmyrdek, looks like my changes were not deployed to production (master merge didn't trigger the deploy job). Could you please do that? :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before the auth implementation, uploading a dependency file didn't require login. This behavior is also described in
project-prd.mdunderUS-002, with no mention of authentication.Current state:
The auth PR introduced
PUBLIC_PATHS, but it looks like theupload-dependenciesendpoint was missed. This PR fixes that by marking it as public - no login required.If uploading dependencies should require login, then we should either:
If we agree this endpoint should stay public, then this PR is good to go 🟢.
I haven’t added any
RATE_LIMIT_CONFIGfor this endpoint. If you think we should add something lightweight (e.g. 1 upload every 5 seconds), let me know and I’ll include it.Br,
Kacper
Roadmap alignment
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.