Fix MockResponse.getheaders() to return headers list instead of None #7050
      
        
          +45
        
        
          −1
        
        
          
        
      
    
  
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Summary
Fixes a bug in
MockResponse.getheaders()method where it was not returning the headers list, resulting inNonebeing returned instead.Problem
The
getheaders()method in theMockResponseclass (used for cookie extraction) was missing areturnstatement, causing it to always returnNoneinstead of the actual headers list.Solution
returnstatement insrc/requests/cookies.pyline 121Changes
src/requests/cookies.py- Addedreturnstatement toMockResponse.getheaders()tests/test_requests.py:test_mock_response_getheaders_returns_headers_list()test_mock_response_getheaders_returns_empty_list()Testing
All new tests pass and verify that: