Add type hints to Response.iter_content #7147
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request adds type hints to the Response.iter_content method to improve static type checking and code readability. The type annotations accurately reflect the method's behavior: accepting an optional integer for chunk size and a boolean for unicode decoding, and returning an iterator of bytes or strings.
Key changes:
- Added typing imports (
Iterator,Union,Optional) from the typing module - Added type annotations to the
iter_contentmethod signature including parameter types and return type
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
|
|
There was a problem hiding this comment.
The addition of a blank line after the typing import creates a double blank line between the standard library imports and third-party imports (urllib3). According to PEP 8, there should be only one blank line separating different groups of imports. Remove the extra blank line on line 16.
| self, | ||
| chunk_size: Optional[int] = 1, | ||
| decode_unicode: bool = False, |
There was a problem hiding this comment.
The parameters in the multi-line function signature are not properly indented. According to the indentation pattern used elsewhere in this file (see lines 260-272, 353-365), continuation lines should be indented with an additional 4 spaces. The parameters on lines 802-804 should be indented to align with the opening parenthesis or use hanging indent with 8 spaces total from the left margin.
| self, | |
| chunk_size: Optional[int] = 1, | |
| decode_unicode: bool = False, | |
| self, | |
| chunk_size: Optional[int] = 1, | |
| decode_unicode: bool = False, |
2 participants
Adds precise type hints to Response.iter_content to improve
static analysis and readability without changing behavior.