refactor(audiorouting): Add the missing functions on the header #341
+23
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharkwouter
reviewed
Jan 3, 2026
Member
sharkwouter
left a comment
sharkwouter
left a comment
There was a problem hiding this comment.
Does that mean that these functions cannot be used yet because the stubs are still missing? Then I'd rather wait a bit before merging.
Contributor
Author
|
That means that the stubs were only added and made available on kernel with the way PSPSDK current is. I believe that was due to historical reasons (maybe because only the kernel functions names were discovered before the PSPSDK project existed) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, I noticed that this lib has a user counterpart, with the same functions. I guess another thing that needs to be done is to also include stubs for the user-space. I'll disccuss that further on discord, but for now this should be good for a PR.