Skip to content

Fix incorrect description of surface_azimuth parameter in get_pvgis_hourly #1838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 22, 2023
Merged

Fix incorrect description of surface_azimuth parameter in get_pvgis_hourly #1838

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
20b9ec6
Fix misleading documentation for surface_azimuth
tongpu Aug 22, 2023
cb51d94
Add docs change to v0.10.2
tongpu Aug 22, 2023
41dee6f
Add docs change to v0.10.2
tongpu Aug 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions docs/sphinx/source/whatsnew/v0.10.2.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,8 @@ Documentation
(:issue:`1722`, :pull:`1723`)
* Fix and update example in :py:func:`pvlib.pvsystem.retrieve_sam`.
(:issue:`1741`, :pull:`1833`)
* Fix error in :py:func:`pvlib.iotools.get_pvgis_hourly`.
(:issue:`1724`, :pull:`1838`)

Requirements
~~~~~~~~~~~~
Expand All @@ -48,3 +50,4 @@ Contributors
* Abigail Jones (:ghuser:`ajonesr`)
* Taos Transue (:ghuser:`reepoi`)
* NativeSci (:ghuser:`nativesci`)
* Lukas Grossar (:ghuser:`tongpu`)
10 changes: 5 additions & 5 deletions pvlib/iotools/pvgis.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,14 +77,14 @@ def get_pvgis_hourly(latitude, longitude, start=None, end=None,
surface_tilt: float, default: 0
Tilt angle from horizontal plane. Ignored for two-axis tracking.
surface_azimuth: float, default: 180
Orientation (azimuth angle) of the (fixed) plane. Counter-clockwise
from north (north=0, south=180). This is offset 180 degrees from
the convention used by PVGIS. Ignored for tracking systems.
Orientation (azimuth angle) of the (fixed) plane. Clockwise from north
(north=0, east=90, south=180, west=270). This is offset 180 degrees from the
convention used by PVGIS. Ignored for tracking systems.

.. versionchanged:: 0.10.0
The `surface_azimuth` parameter now follows the pvlib convention, which
is counterclockwise from north. However, the convention used by the
PVGIS website and pvlib<=0.9.5 is offset by 180 degrees.
is clockwise from north. However, the convention used by the PVGIS website
and pvlib<=0.9.5 is offset by 180 degrees.
usehorizon: bool, default: True
Include effects of horizon
userhorizon: list of float, default: None
Expand Down