Skip to content

added warning message and test for issue #837 #919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

added warning message and test for issue #837 #919

Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a1adf48
added warning message and test for issue #837
ronikobrosly Sep 8, 2024
a3c6439
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Sep 8, 2024
ca78ec0
Updated location of T_res error message
ronikobrosly Sep 25, 2024
1df31c2
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Sep 25, 2024
70cc2dd
Update econml/iv/dml/_dml.py
ronikobrosly Sep 27, 2024
f013ed5
Update econml/iv/dml/_dml.py
ronikobrosly Sep 27, 2024
86c9976
Merge branch 'main' into fix_837
ronikobrosly Oct 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions econml/iv/dml/_dml.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -761,6 +761,14 @@ def predict(self, Y, T, X=None, W=None, Z=None, sample_weight=None, groups=None)
TX_pred = np.tile(TX_pred.reshape(1, -1), (T.shape[0], 1))
Y_res = Y - Y_pred.reshape(Y.shape)
T_res = TXZ_pred.reshape(T.shape) - TX_pred.reshape(T.shape)
if T_res.sum() == 0:
raise ValueError(
"""
All values of the treatment residual are 0,
which then makes them unsuitable to use as weights
in downstream in econml/dml/dml.py
"""
)
return Y_res, T_res


Expand Down
Loading