Diskdetection refactor #520
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Former-commit-id: c62d3e4
…p and port to constraints tomorrow morning. Former-commit-id: a7ee689
…ngle-slice, will do rest of the classes tomorrow. Former-commit-id: c4f4b26
Former-commit-id: 70ed466
Former-commit-id: 689c5b1
Former-commit-id: 793f36a
Former-commit-id: 2864b24
Former-commit-id: a1a1cca
Former-commit-id: 245957f
Former-commit-id: 8aa3b60
Former-commit-id: f6ed108
Former-commit-id: 67dc9dc
Former-commit-id: 2ebfb32
Former-commit-id: fbf3e79
Former-commit-id: ab295ac
Former-commit-id: 7e266f2
Strain refactor Former-commit-id: d1546a9
Former-commit-id: bb09061
Former-commit-id: 4625d39
Former-commit-id: 70f0152
Former-commit-id: 35d442f
Former-commit-id: 9204cae
Former-commit-id: b0e1ac6
Former-commit-id: 0d5ba33
Former-commit-id: 0609c6a
Updating whole pattern fitting for v 0.14.3 Former-commit-id: b51a392
Former-commit-id: 942aec1
Former-commit-id: 1b81b6c
…ings updating some docstrings Former-commit-id: e57c41a
Gdrive hotfix Former-commit-id: b71e7b8
small changes to show Former-commit-id: a188444
Former-commit-id: 2ccc7dd
Former-commit-id: dfc53eb
Former-commit-id: dd1fe21
Former-commit-id: e96a718
Former-commit-id: f0349bb
Listwrite patch Former-commit-id: 3bfbdaf
Former-commit-id: 357467c
Former-commit-id: ca07ddb
older versions seem to have issues downloading some links so updating minimum version Former-commit-id: 840cf3b
Updating gdown version to latest Former-commit-id: b0fbf8c
Former-commit-id: 48c0924
Former-commit-id: cabb90b
nudging python version Former-commit-id: 4d60318
CI/CD - Adding installation checkers Former-commit-id: fb01fa4
reformat repo Former-commit-id: be44354
Former-commit-id: 8824352
Former-commit-id: aaf8d18
Add a GitHub action that checks for `black` styling Former-commit-id: d9daf5d
Former-commit-id: 39a3956
Former-commit-id: c65003c
bsavitzky
force-pushed
the
diskdetection_refactor
branch
from
1c5800e to
348d4cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR draft refactors
find_Bragg_disks. Existing syntax is not affected, instead implementing a new methodfind_bragg_vectorsin this draft.The function call signature and docstring specifying behavior is currently complete. Logic is not yet implemented.