-
Notifications
You must be signed in to change notification settings - Fork 2
feat: add support for Precision-2 (PYA-964) #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for Precision-2 model by introducing the new model as the default for diarization, voiceprint, and identification operations. The changes also enable previously unsupported speaker count constraints and add new confidence and exclusivity options.
- Updates type annotations from
Optional[int]toint | Nonefor modern Python syntax - Adds support for
min_speakersandmax_speakersparameters that were previously disabled - Introduces new parameters:
turn_level_confidence,exclusive, andmodelwith "precision-2" as default
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
src/pyannoteai/sdk/client.py
Outdated
| media://{...} URL created with the `upload` method or | ||
| any other public URL pointing to an audio file. | ||
| model : str, optional | ||
| Defaults to "precision-2" |
Copilot
AI
Sep 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The documentation format is inconsistent. The model parameter should include a period at the end to match the format of other parameter descriptions in the docstring.
| Defaults to "precision-2" | |
| Defaults to "precision-2". |
src/pyannoteai/sdk/client.py
Outdated
| any other public URL pointing to an audio file. | ||
| voiceprints : dict | ||
| model : str, optional | ||
| Defaults to "precision-2". |
Copilot
AI
Sep 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The model parameter documentation is incomplete - it's missing a description of what the model parameter does, unlike other parameters that have descriptive text explaining their purpose.
| Defaults to "precision-2". | |
| Name of the model to use for speaker identification. Defaults to "precision-2". |
src/pyannoteai/sdk/client.py
Outdated
| Defaults to False | ||
| exclusive: bool, optional | ||
| Defaults to False |
Copilot
AI
Sep 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new parameters turn_level_confidence and exclusive lack descriptions explaining their purpose and functionality, making the API unclear to users.
| Defaults to False | |
| exclusive: bool, optional | |
| Defaults to False | |
| If True, includes confidence scores for each detected speech turn in the diarization output. | |
| Defaults to False. | |
| exclusive: bool, optional | |
| If True, ensures that speech turns do not overlap between speakers, enforcing exclusivity in speaker assignment. | |
| Defaults to False. |
No description provided.