Update header files to PKCS#11 3.1 #205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatthiasValvekens
force-pushed
the
maintenance/pkcs11-3.1-headers
branch
2 times, most recently
from
a24979b to
2f7fc5f
Compare
This was referenced Jun 19, 2025
MatthiasValvekens
force-pushed
the
maintenance/pkcs11-3.1-headers
branch
3 times, most recently
from
e2649c9 to
c4cf36f
Compare
- Expose SHA3 digests in Cython layer - Add wiring for EdDSA params
Commit rebased from #164.
MatthiasValvekens
force-pushed
the
maintenance/pkcs11-3.1-headers
branch
from
c4cf36f to
b8fe284
Compare
kislyuk
approved these changes
Jun 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main functional changes:
MechanismWithParamsbranches for better forwards compat behaviour when more mechanisms are added later. See comment in the source.I included the EdDSA params for selfish reasons (namely so that I can finally get rid of this nasty hack: https://github.com/MatthiasValvekens/pyHanko/blob/master/pkgs/pyhanko/src/pyhanko/sign/pkcs11.py#L300-L310). Of course there's all sorts of other fun stuff included in the new headers that is worth adding as well: ChaCha20/Salsa20/Poly1305/XEd25519/... I'll leave that for future PRs.
I slightly modified the header files to match formatting conventions and to take into account some of the remarks on #183. This PR also fixes #145.