Skip to content

Conversation

alex
Copy link
Member

@alex alex commented Nov 26, 2024

This does not currently work because rust-asn1 doesn't handle Asn1Definedby{Readable,Writable} correctly

@reaperhulk reaperhulk requested a review from Copilot January 31, 2025 23:08
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (4)

src/rust/cryptography-x509/src/pkcs7.rs:14

  • [nitpick] The type parameter name 'Op' is ambiguous. It should be renamed to 'Asn1Op' for better clarity.
pub struct ContentInfo<'a, Op: Asn1Operation> {

src/rust/cryptography-x509/src/pkcs7.rs:22

  • [nitpick] The type parameter name 'Op' is ambiguous. It should be renamed to 'Asn1Op' for better clarity.
pub enum Content<'a, Op: Asn1Operation> {

src/rust/cryptography-x509/src/pkcs7.rs:34

  • [nitpick] The type parameter name 'Op' is ambiguous. It should be renamed to 'Asn1Op' for better clarity.
pub struct SignedData<'a, Op: Asn1Operation> {

src/rust/cryptography-x509/src/pkcs7.rs:64

  • [nitpick] The type parameter name 'Op' is ambiguous. It should be renamed to 'Asn1Op' for better clarity.
pub struct EnvelopedData<'a, Op: Asn1Operation> {

This does not currently work because rust-asn1 doesn't handle Asn1Definedby{Readable,Writable} correctly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants