Skip to content

Add cupy ravel #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 35 commits into
base: cuda_main_temp
Choose a base branch
from
Open

Add cupy ravel #21

wants to merge 35 commits into from

Conversation

bauom
Copy link
Collaborator

@bauom bauom commented Sep 5, 2023 •
edited by smazouz42
Loading

This PR will implement the call the cupy.ravel by replacing it call with array creation of a flattened version of the passed array.

TODO:

  • Add unit tests
  • Create separate issue for numpy.reshape
  • Set as blocked by issue above

Pinkyboi and others added 30 commits October 26, 2022 16:54
@Pinkyboi
Add cupy rabel
ba71874
@Pinkyboi
Add docstring for ravel
8207c2d
@Pinkyboi
fix cuda copy array printing
d949086
@Pinkyboi
Fix errors in Kernel Semantic checks
4d56a59
@Pinkyboi
Add tests for cupy_ravel
8719440
@Pinkyboi
Remove unused imports
319d71d
@Pinkyboi
revert back to using more specific type for data pointer
a136516
@Pinkyboi
Merge branch 'cuda_main_temp' into cuda_cupy_ravel
c9b80dd
@Pinkyboi
Add memory location to cupy ravel
918a63d
@Pinkyboi
Add cupy printer
1679229
@Pinkyboi
Avoid calculating rank in ravel
dbb62a9
@Pinkyboi
Separate tests and remove Ravel infere type
dcdc81f
@Pinkyboi
Implement cupy ravel with AliasAssign
7c1ce50
@Pinkyboi
Fix address printing in cupy_ravel
adcf864
@Pinkyboi
Fix typo in cuda_ravel implementation
d938561
@Pinkyboi
Fix case of passed variable
a16bbee
@Pinkyboi
avoid call to _print
5878446
@Pinkyboi
Fix typo in dest nd
a895e71
@Pinkyboi
Remove memory location option for cupy functions
0c9c070
@Pinkyboi
Avoid if statement for memory location
573e03b
@Pinkyboi
Add tests for cupy ravel
3d97f17
@EmilyBourne
Line endings
6127038
@Pinkyboi @EmilyBourne
Remove slot from CupyRavel
2a94f14 
Co-authored-by: EmilyBourne <louise.bourne@gmail.com>
@Pinkyboi
Merge 'cuda_main_temp' of into cuda_cupy_ravel
a0d2c4b
@Pinkyboi
Fix typos in cupy_ravel
27c4250
@Pinkyboi
Fix codacy problems
d83f526
@Pinkyboi
Use managed_memory to allocate shape and strides
5ff5c22
@Pinkyboi
Do a copy for host arrays
d472a7c
@Pinkyboi
Remove _attribute_nodes from CupyRavel
be2fd09
@Pinkyboi
Use tuple instead of list for variable in test
3fb754f
@bauom bauom requested a review from EmilyBourne as a code owner September 5, 2023 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@EmilyBourne EmilyBourne Awaiting requested review from EmilyBourne EmilyBourne is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bauom @Pinkyboi @EmilyBourne