Coerce IndexVariable to Variable when assigning to data variables or coordinates
#10909
+54
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsignell
changed the title
IndexVariable to Variable when assigning to data variables or coordinates
jsignell
changed the title
IndexVariable to Variable when assigning to data variables or coordinatesIndexVariable to Variable when assigning to data variables or coordinates
dcherian
reviewed
Nov 11, 2025
jsignell
force-pushed
the
index-variables
branch
from
af095e7 to
3370345
Compare
dcherian
reviewed
Nov 11, 2025
jsignell
commented
Nov 12, 2025
jsignell
commented
Nov 12, 2025
|
|
||
| def _assert_variable_invariants(var: Variable, name: Hashable = None): | ||
| def _assert_variable_invariants( | ||
| var: Variable | Any, |
Contributor
Author
There was a problem hiding this comment.
The check now happens within this function.
jsignell
commented
Nov 12, 2025
jsignell
commented
Nov 12, 2025
| stacked.coords["variable"].drop_vars(["z", "variable", "y"]), | ||
| expected_stacked_variable, | ||
| stacked["variable"].variable.to_base_variable(), | ||
| expected_stacked_variable.variable, |
Contributor
Author
There was a problem hiding this comment.
This was the only test change that was needed. Basically stacked["variable"].variable is an IndexVariable because it is represents a coord that is part of a MultiIndex. But you can't know that if you only have access to the DataArray with no coords. So I just switched it to be comparing variable and to coerce to the Variable.
Contributor
There was a problem hiding this comment.
yeah multi-indexes are where IndexVariable really bites us
e.g. #8887
Illviljan
reviewed
Nov 13, 2025
Co-authored-by: Illviljan <14371165+Illviljan@users.noreply.github.com>
dcherian
reviewed
Nov 14, 2025
| for k, v in da._coords.items(): | ||
| _assert_variable_invariants(v, k) | ||
| _assert_variable_invariants( | ||
| v, k, check_default_indexes=check_default_indexes, is_index=k in da._indexes |
Contributor
There was a problem hiding this comment.
Suggested change
| v, k, check_default_indexes=check_default_indexes, is_index=k in da._indexes | |
| v, k, is_index=k in da._indexes |
"check default indexes" doesn't mean anything for Variable, which is only data + named dims + attrs
dcherian
reviewed
Nov 14, 2025
| def _assert_variable_invariants( | ||
| var: Variable | Any, | ||
| name: Hashable = None, | ||
| check_default_indexes: bool = True, |
Contributor
There was a problem hiding this comment.
Suggested change
| check_default_indexes: bool = True, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
whats-new.rstNew functions/methods are listed inapi.rst